- Issue created by @amateescu
- Merge request !9726Improve performance for path_alias queries on the revision table β (Closed) created by amateescu
- First commit to issue fork.
- πΊπΈUnited States smustgrave
1) Drupal\Tests\path_alias\Functional\Update\PathAliasRevisionIndexesUpdatePathTest::testRunUpdates Failed asserting that false is true. /builds/issue/drupal-3478240/core/modules/path_alias/tests/src/Functional/Update/PathAliasRevisionIndexesUpdatePathTest.php:36 FAILURES! Tests: 1, Assertions: 179, Failures: 1.
Show test upgrade path is testing correctly.
Applied 2 nitpicky void returns directly.
Issue summary is correctly mentioning the data model change and appears correct.
Reviewing code addition of new index appears correct.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π·π΄Romania amateescu
Weird that CSpell passed on the DrupalCI pipeline but failed the NR bot, hope I found and fixed the problem.
- π¬π§United Kingdom catch
Committed/pushed to 11.x, thanks!
Moving to to be ported for 10.4.x because I can't make my mind up about the post update, will get a second or more opinions.
I think we have a regression report at: π Translating path aliases in workspace does not work Active .
- Status changed to Fixed
30 days ago 1:07pm 6 January 2025 - π·π΄Romania amateescu
I think it's too late to backport this to 10.4.x now, and the regression pointed out above should get into 11.1.x since it's only a bugfix.
Automatically closed - issue fixed for 2 weeks with no activity.