seantwalsh → credited froboy → .
seantwalsh → credited froboy → .
seantwalsh → credited froboy → .
tekNorah → credited froboy → .
https://git.drupalcode.org/project/lb_cards/-/merge_requests/45 is ready for review
I'd imagine this is a heavy enough lift that it'd need to wait until D.o is upgraded to D10. Could maybe be a use case for ECA if it's on there.
froboy → created an issue.
@danielzigo same here... it'd be great to assign credit → to the folks who worked on this.
@danielzigo thanks so much! If you don't mind, could you check the attribution boxes to assign credit. Thanks!
tekNorah → credited froboy → .
Reopening this for consideration on the 3.x branch. I think it could be a useful addition. Will try to come back to it with updates if it's wanted.
Config to be imported...
On /admin/structure/views/view/community_events/edit/upcoming_events:
- 2-Upcoming events
- DrupalCon Events
I think that's it, but I may have accidentally changed some globals. I didn't get a backup of the view initially so it's hard to be sure.
On /node/3129564/panelizer/default/content:
- I mostly just disabled panes and edited text in "Missed an event". I can recreate most of this on prod.
I've made these changes in the dev site and they can be seen in this screenshot. Unfortunately previewing them live is impossible until the CSS changes are integrated.
When complete, these styles should render as above.
- DrupalCon pane has a background and border. Image is set right, content is set left.
- Upcoming Events pane has exposed filters, images are set right, text is set left.
- Center pane is only one column.
It's been a minute. Here's a rerolled patch for 8.x-2.12. Interdiff shows only indexes and surrounding text have changed.
Thanks @olegrymar. Be sure to bump the library version next time.
Thanks folks. Tested and merged.
froboy → changed the visibility of the branch 3442914-montserrat-override to active.
froboy → changed the visibility of the branch 3442914-montserrat-override to hidden.
I've merged https://git.drupalcode.org/project/ws_colorway_canada/-/merge_requests/12 and tagged 1.1.9 → .
It's not quite as simple as I thought. One more fix.
New patch resolves the issue in #40.
@vineshmalviya it looks like you're new here, welcome! You've uploaded a patch to an issue with a MR. Please review Using GitLab to Contribute to Drupal → to understand the new workflow. I'd also recommend adding some more complete test steps so that we can properly validate the problem you're seeing.
Thanks!
(also doing cleanup to hide patch files since this in using a MR now)
I disagree here. Making un-scoped changes to base HTML tags and !important can have unintended consequences across the Drupal admin, contextual links, and more. We should be more thoughtful about how to set these variables in our components in order to maintain the proper CSS cascade instead of overwriting it completely.
I recommend we revert these changes.
@drumm I see a bunch of phpcs errors/warnings, but I'd imagine much of that is preexisting tech debt and not from the changes in this issue. How would you recommend moving forward?
If you have a bunch of existing blocks it may be useful to run an update hook to set the them all to be non-reusable. Here's what I did so it might help others:
/**
* Set blocks that should not be reusable to non-reusable.
*/
function my_module_update_9001(&$sandbox) {
$count = 0;
$block_storage = \Drupal::service('entity_type.manager')->getStorage('block_content');
$ids = \Drupal::entityQuery('block_content')
->condition(/* Some condition if you're able to identify only certain block types to fix. */)
->condition('reusable', '1', '=')
->accessCheck(FALSE)
->execute();
foreach ($ids as $id) {
// Loop through blocks and set them to non-reusable.
/** @var \Drupal\block_content\Entity\BlockContent $updated */
$block = $block_storage->load($id);
$updated = $block->setNonReusable()->save();
if ($updated == 2) {
$count++;
}
}
\Drupal::messenger()
->addMessage(t('Updated @count blocks.', [
'@count' => $count,
]));
}
This won't be useful to too many folks, but here's #46 that applies to the now abandoned 2.x branch.
This seems like it might be a duplicate of ✨ Fails on translated inline blocks Closed: duplicate . That's had a little bit more testing, so I'd recommend we consolidate efforts there.
Branch updated.
@drumm it looks like @aangel did open a branch, but missed creating the MR. I've done that: https://git.drupalcode.org/project/restws/-/merge_requests/2
To be merged with https://github.com/YCloudYUSA/y_lb_demo_content/pull/44. Requires database update.
As seen here, this new MR supports varying heights on cards with either button position.
@carolpettirossi @olegrymar I disagree with this approach. It took a minute to dig up, but the inline heights are being set by the legacy jQuery MatchHeight functionality in openy_carnation:
After going into that page and removing the card styles from the MatchHeight configuration, the cards now resize correctly.
Please review and if you agree we can mark this "Closed, works as designed."