- π§πͺBelgium jOpdebeeck
Remade the patch from #48
Re-rolled #40 for 9.4.12
- π¬π§United Kingdom AndyF
It looks like there's an unanswered question of ticket scope: are we only interested in external URLs, or should we also deal with internal? Personally I'd suggest that if we can't simply solve both, then it makes sense to at least support external URLs along the lines of #31 and if we want to handle internal links do that in a separate ticket. The only issue with #31 that I can see is the slight WTF you'd get from adding an entirely separate query param to such an external URL: I don't think you'd expect that to change how the duplicate query parameters are handled. ie...
// Assuming we're using a solution that only implements #31. \Drupal\Core\Url::fromUri('https://example.com/page?tag=one&tag=two')->toString(); // Returns https://example.com/page?tag=one&tag=two \Drupal\Core\Url::fromUri('https://example.com/page?tag=one&tag=two', ['query' => ['foo' => 'bar']])->toString(); // Returns https://example.com/page?tag=two&foo=bar
@carolpettirossi could you give any extra detail on why/how you're using local links with duplicate query parameter names? Thanks!