CKEditor 5: Javascript error when plugin settings has NULL value

Moving to 10.3.x

By mistake, I created this for 10.2.x. I've changed the Version field to 10.3.x, but I don't know how to rebase the issue branch and MR. If someone can help, I'd appreciate it.

Should actually target 11.x as the current "main" branch. Bugs can be backported.

MR should be updated too.

The scenario may be valid, not sure if it's a bug in the custom code though. But will need a failing test to show the problem.

It's not clear to me what the steps to reproduce are. It's also not clear to me if "just NULL" ever makes sense — it'd make more sense to not have any configuration at that point? 🤔😅

@wim-leers I bumped into this when I was writing a plugin to add the Text Transformation feature into CKEditor 5. I've made it (BTW, I've written a module for that → ), but trying some plugin advanced configs, I noticed some of them needed returning NULL values. For example, the extra config with regular expressions:

Looking at core/modules/ckeditor5/js/ckeditor5.js code, I found out that I could return a RegExp as config using a structure like this (on a CKEditor5Plugin or hook_ckeditor5_plugin_info_alter implementation):

return [
  // ... 
  'extra' => [
    [
      'from' => ['regexp' => ['pattern' => '/(^|\s)(")([^"]*)(")$/']],
      'to' => [NULL, '«', NULL, '»'],
    ],
  ]
];

However, when I did this, the editor got broken, and a JS error on the browser console pointed to an error on ckeditor5.js. Then, looking at processConfig()'s code, it assumes the config parameter is always a valid Object, but in Javascript, typeof null === 'object' (which is crazy), so when config is null, the error occurs.

My MR just adds a null check for the config parameter.

Oh … intriguing! Thanks a lot for that clear explanation! 👏

Explicit test coverage for this seems totally overkill for that simple oversight and trivial code addition 👍

Committed and pushed 695c6a53ca to 11.x and 0590956f51 to 10.3.x and 4fb6e509bf to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.