- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
+++ b/core/modules/field_ui/field_ui.js @@ -365,10 +365,14 @@ - : this.$pluginSelect.find('option')[0].value; + : pluginSelect;
I think we can just write this as
this.$pluginSelect.find('option')[0]?.value
for the D10 version where we don't have to support IE11 in D10+https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operat...
We still need this dance for the D9 version though.
- Status changed to RTBC
over 1 year ago 7:09am 23 January 2023 - 🇳🇱Netherlands Spokje
@larowlan: I think you're spot on (per usual) and this approach was tried in #23 🐛 Uncaught TypeError: this.$pluginSelect.find(...)[0] is undefined Fixed .
Sadly, as @znerol already discribed in #25 🐛 Uncaught TypeError: this.$pluginSelect.find(...)[0] is undefined Fixed ,
scripts/dev/commit-code-check.sh
isn't ready for optional chaining in JavaScript (yet?). See https://www.drupal.org/pift-ci-job/2561443 → for the "TestBot-Says-No!" result.I'll open a follow-up so that can be addressed, but I think, since this is a Major, we should get this in ASAP and not postpone this on our tooling not being up to scratch. So back to RTBC. Happy to be educated on why this was a potential bad status change.
INSTA-EDIT: Opened 📌 commit-code-check.sh doesn't allow optional chaining in JavaScript Fixed for the
commit-code-check.sh
woes. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Yep I agree with that approach - will pick this up tomorrow
- 🇳🇱Netherlands Spokje
Probably too late in larowlan-land by now *shakes fist in anger at time zones*, but it would be nice if we can get this Major one in.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Adding issue credits, crediting @SandeepSingh199 as I disagree with @smustgrave and feel they were trying to help the issue move forward
Crediting @smustgrave and @Spokje for keeping the issue moving, issue summary updates, filing follow ups etc
-
larowlan →
committed d6689fcb on 10.1.x
Issue #3305706 by znerol, SandeepSingh199, ivnish, smustgrave, Spokje,...
-
larowlan →
committed d6689fcb on 10.1.x
-
larowlan →
committed 6e64287f on 10.0.x
Issue #3305706 by znerol, SandeepSingh199, ivnish, smustgrave, Spokje,...
-
larowlan →
committed 6e64287f on 10.0.x
-
larowlan →
committed b11a861d on 9.5.x
Issue #3305706 by znerol, SandeepSingh199, ivnish, smustgrave, Spokje,...
-
larowlan →
committed b11a861d on 9.5.x
- Status changed to Fixed
over 1 year ago 1:04am 26 January 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and backported to 10.0.x
Committed to 9.5.x
Sorry for taking a bit longer, yesterday was busy.
- 🇳🇱Netherlands Spokje
Thanks @larowlan
Sorry for taking a bit longer, yesterday was busy.
No worries, that's why I desperately try to avoid terms like "tomorrow" without adding "-ish" to cover my behind... ;)
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
3 months ago 1:44pm 30 May 2024 - 🇺🇸United States smustgrave
Closed 🐛 Uncaught TypeError: Cannot read properties of undefined (reading 'value') Needs review as duplicate