- Issue created by @spokje
- πΊπΈUnited States mherchel Gainesville, FL, US
+π― on getting this fixed. Optional chaining has the opportunity to reduce a lot of unnecessary
if
statements - last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 2:33pm 12 September 2023 - last update
about 1 year ago 30,148 pass - last update
about 1 year ago 30,148 pass - πΊπΈUnited States mherchel Gainesville, FL, US
Should the example failed?
- The example in #5 fails because it has optional chaining (but not the fix).
- The example file in #6 passes because in addition to the file with optional chaining, it contains the fix. This demonstrates that the patch works as intended!
- Status changed to RTBC
about 1 year ago 8:16pm 12 September 2023 - π¬π§United Kingdom longwave UK
Confirmed with caniuse.com that all ES11/ECMAScript 2020 features can be used in modern browsers that we support; see "Feature support list" at https://caniuse.com/sr_es11
Backported to 10.1.x to allow us to keep JavaScript changes in sync more easily if needed.
Committed and pushed 91c7840 to 11.x and 0372205 to 10.1.x. Thanks!
Also added a release note in case others are using our ESLint config.
- Status changed to Fixed
about 1 year ago 8:42pm 12 September 2023 -
longwave β
committed 03722059 on 10.1.x
Issue #3335653 by mherchel, Spokje: commit-code-check.sh doesn't allow...
-
longwave β
committed 03722059 on 10.1.x
-
longwave β
committed 91c7840b on 11.x
Issue #3335653 by mherchel, Spokje: commit-code-check.sh doesn't allow...
-
longwave β
committed 91c7840b on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.