🇪🇸Spain @nuez

Thank you.

Fixed in dev.

Sounds like a z-index issue?

Can you please give me more information about how you link?

Are you using linkit, or the drupal link?

Please give me the steps to reproduce this and i'll try and fix it.

thanks

I'm not sure if this should be the responsibility of the embedded_content module or the plugin creating the markup.

However I would like to be able to reproduce the issue on my local environment: Could you provide the exact steps to reproduce this issue, with module version numbers, themes and modules installed,

Thanks!

I've revised the dependencies give them both ^6 ||  ^7 constraints so they are compatible with d10 and d11.

Thanks! I forgot about the examples module. opening this issue again.

This functionality was added to the https://www.drupal.org/project/embedded_content → module which supersedes this one.

The https://www.drupal.org/project/embedded_content → module , superseding this one, offers this functionality now.

Yess, I like your choice of music.

You can look at the https://www.drupal.org/project/embedded_content_examples → module for an example.

This issue is addressed in the embedded_content module which replaces this one. https://www.drupal.org/project/embedded_content →

This module will not receive an update to Drupal 11 as it is replaced by https://www.drupal.org/project/embedded_content → which does support Drupal 11.

To update to embedded content, simply download the 2.0.x version of this module, download the embedded_content module, run the updatehook and remove the ckeditor5_embedded_content module.

Thanks for your feedback. I've fixed this and will create a new release. Please let me know if you still have issues.

Sounds like a plan!

You can now apply the core patch: this module should work with and without it.

I've added the necessary code to make multiple modals work out of the box when the patch from https://www.drupal.org/project/drupal/issues/2741877 🐛 Nested modals don't work: opening a modal from a modal closes the original Needs work is applied. If not, it will also work, just not with multiple modals such as the ones opening up in the Media Libarary.

Changes have been based on some of the suggestions made in https://www.drupal.org/project/ckeditor5_embedded_content/issues/3306230 ✨ It is not possible to have the embedded content modal open another modal. Needs review , hence the due credits.

This is probably because you applied a core patch:

https://www.drupal.org/project/drupal/issues/2741877 🐛 Nested modals don't work: opening a modal from a modal closes the original Needs work

The saveCallback.has only exists when applying the core patch for multiple modals. I'm working on a patch for this module as well, based on the issue https://www.drupal.org/project/ckeditor5_embedded_content/issues/3306230 ✨ It is not possible to have the embedded content modal open another modal. Needs review

This issue is the same as the original issue in the Ckeditor5 Embedded Content module.

https://www.drupal.org/project/ckeditor5_embedded_content/issues/3306230 ✨ It is not possible to have the embedded content modal open another modal. Needs review

That issue will no longer apply as the module has changed names to this one. I'm changing the issue description to copy the previous issue.

Hi,

This module has been renamed to Embedded Content → . Please file this issue there again and close this one.

As for external integrations:

Best would be to create modules in the 'embedded_content' namespace such as the already existing:

• Embedded Content Examples →
• Embedded Content Single Directory Components (under development) →
• Embedded Content Entity →

The examples module is now a separate module in https://www.drupal.org/project/embedded_content_examples →

This issue is addressed in the Embedded Content → module.

nuez → created an issue.

nuez → made their first commit to this issue’s fork.

nuez → created an issue.

The reroll from #123 seems to be missing a few things. Embedding media doesn't seem to work with this reroll.

I've literally rerolled the d10 patch from #119 and there are a few differences.

Thanks for the issue.

I am not sure what the best approach would be:

1. Show the button but instead of rendering the plugin configuration form show an 'access denied message'?
2. Not show the button at all
3. Should we have a seperate permission in the first place? In the end adding the button to the filter, which has it's own permission, should be good enough? I suggest removing the permission in the version 2 altogether.

What do you think?

Thanks @Josh Waihi for this report.

This is fixed in the latest 1.0.x release. Please let me know here if this works for you.

Sorry I hadn't pushed anything yet. I have now. The module is not working yet, but could maybe a starting point for further development.

Two reasons why I prefer having separate modules instead of one module with submodule:

1. You can get a stable release for the main module while the submodule is still on alpha/beta/dev releases.
2. If you don't use SDC but you do use embedded_content, you don't end up with code you are not using.

I have started work on this in https://www.drupal.org/project/embedded_content_sdc → , maybe you want to have a look there.

I think this is actually a core bug: https://www.drupal.org/project/drupal/issues/3401827 🐛 drupalSettingsLoader removes changes in DrupalSettings added in ajax requests Active

nuez → created an issue.

nuez → created an issue.

nuez → made their first commit to this issue’s fork.

nuez → created an issue.

nuez → created an issue.

Thanks @jrockowitz!

Happy to facilitate things for Schema.org Blueprints, but i wouldn't mind a quick tour. Please ping me on slack to maybe schedule a meeting and discuss.

About the embedded_content namespace: i guess that would be good, if it's still available. At first i thought this was so specific to ckeditor5 because of the up and down casting, also people are looking for ckeditor5 compatible solutions right now.
But i guess if there is no conflicting alternative, we could change to embedded_content. Curious to see what others think?

Still working on getting some time/funding to work on version 2, but I hope to book some progress on it this month.

Allow choosing between regular and offset modal and customize settings such as height and width

This issue is will be addressed in 📌 Introduce embedded content configurations for different editors Active .

nuez → created an issue.

nuez → created an issue.

nuez → created an issue.

nuez → created an issue.

Thanks for the heads up. This is now fixed in the dev branch.

I agree that stacked modals might be not be a great idea UI wise, but it is a reality that cannot be ignored imho, and for which there is no real alternative.

The offset canvas modal is a solution to one extra layer. Opening the ckeditor5_embedded_content in an offset canvas would solve some issues, but that means that you can't use it in a block body, since that one also opens in an offset canvas. Maybe we should make it configurable that it opens in either offset or modal. That could solve some use cases. I'll put it on the roadmap for 2.x.

Thank you for the reroll!

As you know the nested modals issue is a very old issue affecting a lot of use cases. I've proposed a solution in that issue , that might have an API change, non breaking though, ( https://www.drupal.org/project/drupal/issues/2741877#comment-13559133 🐛 Nested modals don't work: opening a modal from a modal closes the original Needs work and later)

The issue is already 3 years old, but i think my suggestion is still the approach of the subsequent rerolls in that same issue.

@larowlan do you think we can move that issue forward and see if we can land it in core?

I'll have a chat with wim leers on slack see if he can help as well

Cheers,

As far as I can see this is addressed in the 1.0.1 issue. Feel free to reopen if this is still an issue.

OK, i've updated the composer file and removed the composer.lock file since i think it shouldn't be necessary in the first place. Can you please confirm if it's working on the 1.0.1 version? Thanks

Thanks!

Thank you, I've incorporated the suggestions in the latest dev release. Feel free to reopen if this is still is an issue

I've added build instructions to the readme and added tests to test this. Thanks for the work on this @leanderjcc!

Thank you this was addressed in the latest commit.

I think @Kakoums answer suffices.

Thanks!

Thank you

Thanks for noticing,

"address" was indeed a copied file. 🤓. I've addressed both issues in the dev branch.

Much cleaner and with the test and all. thank you very much. Will have a look at this over the next couple of days.

smustgrave → credited nuez → .

Great thanks for the suggestion

nuez → created an issue. See original summary → .