Extraneous comma in Embedded Content button element's CSS classnames

Created on 22 October 2024, about 1 month ago

As I was developing some custom CSS rules for the Embedded Content button (svg) icon, I noticed that the custom <button> element in the CKEditor5 toolbar contained the following class attribute values (I tried to highlight the comma after "ck-button_embedded-content" below, but was unsuccessful):

class="ck ck-button ck-button_embedded-content, ck-button_embedded-content__{button-id} ck-off"

It appears that this comma is generated in line 40 of the js/ckeditor5_plugins/embeddedContent/src/ui.js file:

class: `ck-button_embedded-content, ck-button_embedded-content__${id}`,

In the attached patches (one based on the 2.0.2 tag, the other on the 2.0.x default branch), I removed the extraneous comma from the ui.js file, and rebuilt the js/build/embeddedContent.js file, and this seems to produce a cleaner <button> element in the CKEditor5 toolbar:

class="ck ck-button ck-button_embedded-content ck-button_embedded-content__{button-id} ck-off"

I have the sense that providing patches is not a great way to provide feedback anymore, but I wasn't sure how to use the Web IDE to rebuild the JS file, so I hope this is helpful. And thanks for a great module!

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024