Drupal 10 and Simplenews 4 compatibility

Created on 4 August 2023, 11 months ago
Updated 12 October 2023, 9 months ago

Problem/Motivation

As of now, simplenews_scheduler is not compatible with either Drupal 10 nor simplenews 4. I recommend jumping directly to simplenews 4, since 3 shall never get a stable release. (See here → ). This would lead to a version 3 of simplenews_scheduler.

Proposed resolution

The organization I work for ( KRZN → ) would do this work. To achive this, we need co-maintainership and like to be included as supporting organizations for the Drupal 10 port in case of success.

  1. Include fixes from Automated Drupal 10 compatibility fixes 📌 Automated Drupal 10 compatibility fixes Fixed
  2. Include fixes from Drupal 10 compatibility fixes 📌 Drupal 10 compatibility fixes Closed: duplicate and give credits to the contributers
  3. Fix remaining upgrade-status scanner results (just one or two remaining)
  4. Ensure compatibility with simplenews 4 (looking good at first glimpse)
  5. Because it has been RTBC for a long time and out of own interest, include improvements from Create new 2.0.x Version 📌 Create new 2.0.x Version Needs work

Remaining tasks

Grant co-maintainership to me and/or at least one of my colleagues

  1. https://www.drupal.org/node/3044026/users →

As you can see, it is not the first module we support and we have a mixture of active and lesser active community members. It is our goal to keep increasing the support for the Drupal community.

🌱 Plan
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany JoCowood Kamp-Lintfort

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @JoCowood
  • 🇩🇪Germany JoCowood Kamp-Lintfort
  • 🇩🇪Germany JoCowood Kamp-Lintfort
  • 🇨🇭Switzerland Berdir Switzerland

    This should have been two different issues IMHO, one to get co-maintainer access and one for the plan. Otherwise it would have gotten weird to follow the process as the maintainer issue needs to be moved to a different project then.

    2.x is in a weird state right now as -dev is actually for simplenews 3.x now. That really should have been part of a new major version. That's a rather weird situation. We have some legacy projects that haven't been confirmed yet for D10, I'll touch this again when that finally happens. We're stuck on older simplenews versions and I might need to figure out a way to handle that. I'd suggest not touching 2.x at all, no release or nothing, so we could revert those changes if we need to.

    That said, I've made you a co-maintainer now. Please do whatever you do in a new major version. Maybe even skip 3 and go directly to 4 to maintain version parity with simplenews, should make it easier to understand which version to use?

  • 🇮🇹Italy marajah

    Hi, I am interested as well in this module for a blog. I am now relaying on an external service but it would be great to keep all the users db inside Drupal. Is there any chance that this can be updated to simplenews 4? I can't bring very much, I can't write in PHP, but I can help with translations and documentation if it is needed.

  • First commit to issue fork.
  • Status changed to Fixed 9 months ago
  • 🇩🇪Germany JoCowood Kamp-Lintfort

    We released 4.0.0-alpha1 a few minutes ago. Branch 4.x is based on 2.0.0-alpha1. The release contains all Drupal 9 compatibility fixes, which were missing in tag 2.0.0-alpha1. It also contains all Drupal 10 compatibility fixes. It does not contain anything more, because of the coding guidelines for new major releases → .

    We decided to update core_version_requirement to "^9.3 || ^10" because of the compatibility to simplenews 4.x.

    My colleague Goldfit did the neccessary compatibility fixes based on 3289677 📌 Automated Drupal 10 compatibility fixes Fixed and the non-code-clean-up changes from SvenRyen in 2.0.x development branch.

    I did the review and test and there was a review and test by Bushra Shaikh in 3289677 📌 Automated Drupal 10 compatibility fixes Fixed . Sorry, that we left out the "RTBC" state.

    We fixed the points 1 to 4 of the proposed solution. Point 5 will be moved to a new issues and will lead to a new release.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024