FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/ckeditor5_embedded_content/README.txt
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 100 characters
10 | WARNING | Line exceeds 80 characters; contains 86 characters
-------------------------------------------------------------------------------------------------------------------
FILE: ...rib10/drupal10/modules/contrib/ckeditor5_embedded_content/modules/ckeditor5_embedded_content_examples/ckeditor5_embedded_content_examples.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
--------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/ckeditor5_embedded_content/src/Form/EmbeddedContentDialogForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
13 | WARNING | [x] Unused use statement
71 | ERROR | [x] Expected 1 space after IF keyword; 0 found
71 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
75 | ERROR | [x] Expected 1 space after IF keyword; 0 found
75 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
82 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 4 empty lines
84 | ERROR | [ ] More than 2 empty lines are not allowed
85 | ERROR | [ ] More than 2 empty lines are not allowed
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/ckeditor5_embedded_content/src/Plugin/Filter/EmbeddedContent.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
84 | ERROR | [x] Expected 1 space after IF keyword; 0 found
84 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
86 | ERROR | [x] Expected newline after closing brace
93 | ERROR | [x] Expected newline after closing brace
93 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/ckeditor5_embedded_content/src/Controller/EmbeddedContentPreview.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
90 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml modules/contrib/ckeditor5_embedded_content
Closed: outdated
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Charchil Khandelwal → made their first commit to this issue’s fork.
Patch #2 applied cleanly, and all errors and warnings are fixed.
So moving it to RTBC.
Thanks
Thank you this was addressed in the latest commit.