🇺🇸United States @geerlingguy

Thanks for the update, and for making some progress on the module's Drupal 10 compatibility!

Ditto.

If I have aggregate CSS and JS enabled (I don't use AdvAgg on my site, however), then I get:

If I turn off aggregate CSS and JS in Performance settings, and flush all caches, and then go back to a node form with a textarea (no editor attached), and try again, I get the same errors as above.

Confirmed I have the patched code in the codebase, I am using composer patches to apply:

    "extra": {
        "patches": {
            "drupal/insert": {
                "Fix image insert in Drupal 10": "https://www.drupal.org/files/issues/2024-02-13/insert-3402009-handle_no_CKEditor_instance_3.patch"
            }
        }
    }

Then running composer update.

Just wanted to confirm the beta3 version did not fix the CKEDITOR bug when it's not enabled, but I will hopefully have time to test your latest patch soon as well—hopefully that'll fix it!

Potentially related: 🐛 Can't Insert images into textareas after Drupal 10 upgrade Active

Up until Drupal 10, I was using Insert to insert images into bare textareas, and it has always worked great.

But after upgrading to Drupal 10 I am getting errors about CKEDITOR not being available, I'm guessing that's because the code is meant to work with earlier versions—but is there a way that in the interim (before CKEditor 5 support is added), this module could be made to work without a Text Editor present like before?

Hmm... even if I attach CKEditor to my Full HTML text format for the field, I get those two errors.

It seems like Insert module's CKEditor.js is assuming something's there that's not.

Possibly related? ✨ Separate Ckeditor 4 in a submodule Fixed

geerlingguy → created an issue.

I can confirm the module works (with the same quirks it had in Drupal 8/9) in Drupal 10.

Also seeing this issue, will be happy to see it fixed so my cron logs are a bit cleaner :)

I can also confirm that when running composer require 'drupal/classy:^1.0', my site also had stable installed, so no need to do both separately...

Updating dependencies
Lock file operations: 2 installs, 0 updates, 0 removals
  - Locking drupal/classy (1.0.2)
  - Locking drupal/stable (2.0.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Downloading drupal/stable (2.0.0)
  - Downloading drupal/classy (1.0.2)
  - Installing drupal/stable (2.0.0): Extracting archive
  - Installing drupal/classy (1.0.2): Extracting archive

New release: https://www.drupal.org/project/simple_mail/releases/2.0.1 →

Please open any new bugs found for Drupal 10 use of this module in a new issue. Thanks!

I'm open to someone else taking ownership of this module (I don't use it anymore, so the motivation to keep maintaining it is not quite there), but as it is an active module in use many places, I need to ensure whoever takes over the module will keep it running smoothly (email is a fickle beast) above all else.

Having been away from Drupal dev (besides keeping my blog up to date), I would not qualify myself as the best judge for who could or couldn't take over maintainership for my projects...

Sorry, I only check Slack every month or so nowadays, and I'm guessing your email may have gotten into spam somehow :(

I don't really maintain this module at all anymore, so I'd be okay with someone else taking over as I don't have the time to get it upgraded for full Drupal 10 compatibility.

Thank you for all your years of dedicated work: for the code, the community, the relationships, everything!

As with many others in this thread... you're literally the reason I dove headfirst into the Drupal community many years ago. Thank you, and I hope you continue to spread the fervor and optimistic open source love wherever you go!

quietone → credited geerlingguy → .

Subscribing and adding that yes, this is a bit of a tricky problem to solve. There are few fields that implement a remove button (e.g. File/image fields and a few other custom fields), and it's hard (and annoying) to build in a 'Remove' button on custom multi-value fields, but it would be a huge UX win if we had this out of the box for multi-value fields.

I'm coming over from #2035753: Add 'remove item' function to multi-value autocomplete widget → .

Note also that there's a contrib module that does what would be nice to do in core for multi-value fields: Multiple Fields Remove Button →