Undefined array key

Hello,
Thank you for letting us know.

I've passed your details to the programmer staff.

We will write back to you within 3 business days when we get any results.

Please, wait.

Hello.

Please try to reinstall the plugin.

If this doesn't help, reach us out via our support system:
https://cleantalk.org/my/support/open

Thank you!

I tried reinstalling. It didn't help. Ticket opened.

Hello.
Thank you for your feedback.
We replied to your ticket.

Had same warnings after upgrade. Reverting back to 9.2.3.

Hello _kom__,
Could you also contact us here: https://cleantalk.org/my/support/open ?
Maybe it will be possible to fix the issue faster.

I too was encountering this issue after updating to 9.2.5.

I initially downgraded to 9.2.3 as a temporary ‘fix’. I then followed the suggestion above and uninstalled and reinstalled the module. Unlike others, this *appears* to have resolved the problem for me.

Hello Janner,
Thank you for your feedback.

I've also added this information to the task.

I tried re-installing a second time, but this time I made sure to completely uninstall first. As noted by @Janner, this seems to have solved the problem. I'm not seeing any more errors or warnings. I did have to go back and re-adjust my site settings, though.

Thank you for your feedback.

We are glad to know the issue is solved.

I don't think that uninstalling/installing method is a right way to fix issue. At least it looks like that 9.2.5 release is incompatible with previous releases. So you need to release a new MAJOR version of Cleantalk (and point out this incompatibility) or provide a way to upgrade between two PATCH versions without total module removing.

Hello,

Unfortunately, we're unable to reproduce the issue. If anyone still has the issue, please contact us via support system: https://cleantalk.org/my/support/open

Thank you!

@znaeff, there are at least three independent cases where this bug have been met. What is the reason to hide additional info behind private support system?
It looks like update procedure should have some post-update handler to change something in configuration.
By the way, what environment have you used when reproducing the issue (Drupal version, PHP version, etc.)?
My are: Drupal 10.1.2 and PHP 8.1.21.
Warnings appear regardless of whether SFW is enabled or not.

Hello @_kom__,

Our environment is the same. Unfortunately, we cannot reproduce this issue on our side.

We need some personal information from you, and we can't discuss it here. So, if the issue persists, please contact us via support system: https://cleantalk.org/my/support/open

@znaeff, I've replied you many times: I can't give you administrative access to production site. And nobody, I think.
You have to find some other way to fix issue.

Hello @_kom__ ,

We need to debug these notices in the occurred hosts. We actually understand what sometimes it is impossible to you to give the administrative access to your website.
If it possible, just do some debug stuff what happening in line modules/cleantalk/src/EventSubscriber/BootSubscriber.php:176 (see the screenshot code.png) after the module updated.

This is the another way to fix the issue. Hope to your help!

@Glomberg, thanks a lot for advice.
I'm going to make some experiments.
I will write back to you within 3 business days when I get any results :)

Please, keep us informed.

Three pages of warnings undefined array key "handler" and "next_call"on drupal 9.5.10 & 8.1. Upgraded to 9.2.5, resolved by downgraded back to 9.2.3.

@sioux Thank you for the information. Did you try to re-install 9.2.5 after completely removing the previous version?

Usually, if the update is not compatible with the previous version, then extra installation information needs to be provided. I chose to downgrade and let the bugs be resolved.

I'm here with some results.
1. First I tried to exclude any "cache issues" when standard upgrade process occurs via composer update drupal/cleantalk. Hence, I've flushed all caches not only after upgrade, but before too via drush cr. It didn't help - I've got these 3 warnings on local machine again (noticed that they repeates every 3 minutes).
2. Because full testing of Cleantalk module can be performed only on production site special care should be taken if something will goes wrong and one can revert changes very fast. So I've applied the following procedure:
3. All cofigurations files on local and remote (production) machines were syncronized between databases and local configuration folders.
4. Then, on local machine I've uninstalled module via /admin/modules/uninstall page. Fortunately, only two configs changed in site database: 'core.extension' and 'cleantalk.settings'. Uninstall procedure removes all tables cleantalk* in database (with one exception, see below) as well.
5. Then, via standard procedure: composer update drupal/cleantalk, drush cr and after update drush cim to restore module installed with saved configuration.
Nice result: now there is no errors in watchdog. And all tables have restored in database.
6. On this stage we can more or less safely apply this on production site. I've pushed/pulled composer.lock via git to production site and have applied the above "uninstall-update-install" procedure (we need to use composer install, of course). Well, no errors in watchdog and all module settings remained intact.

Conclusion.
Because with standard update procedure all database tables stay intact and uninstall/install procedure recreates them, it can be concluded that the cause of the bug is incompatibility of some old table content or maybe of tables structure itself with new version of php code.
Maintainers need to provide some "update db" procedure that makes required changes in database table. Of course, it is "breaking changes" (along with moving temporary sfw folder in new location), so it is better to make a new MINOR version of Cleantalk.

PS. There is one table, namely 'cleantalk_ac_ua_bl' that isn't removed by uninstall procedure, but it's content is deleted. It is one more small bug in deinstallation process.

Hello @sioux @_kom__ ,
Thank you for your feedback.

I've added this information to the task. We will check what we can do.

We will write back to you within 3 business days when we get any results.

Please, wait.

PPS. And there's another one minor bug: the version 9.2.3 in admin interface on Cleantalk site has't changed to 9.2.5. Five days left.

Thank you for waiting.

We've released a new version 9.2.6 with fixes. Please update our plugin and recheck this issue.

Please, keep us informed.

I update to 9.2.7 and the keep the warnings, I had to back to 9.2.3 and works

Hello @drw,
Are you getting the same errors?

Yes, the same error:
"Warning: Undefined array key "handler" in Cleantalk\Common\Cron\Cron->runTasks() (line 320"

Does version 9.2.7 provide any "update db" procedure?

@drw, @_kom__ Our developers will check this. We will contact you within 1-2 business days.

@drw, we were not able to reproduce the issue. For further investigation please contact us by our Private Ticket system:

https://cleantalk.org/my/support/open

I'm also seeing the same error.

Hello @OMD,

For further investigation please contact us by our Private Ticket system:
https://cleantalk.org/my/support/open

That's not how Drupal troubleshooting works. It's handled here in the Drupal issue queue, so everyone can benefit from the problems and solutions.

We cannot fix this problem on our end because it is not reproducible. If anyone can provide us with access, then we can fix this problem.

@_kom__, 9.2.6 version adds cron tasks

https://git.drupalcode.org/project/cleantalk/-/blob/9.1.x/cleantalk.inst...

but 9.2.6 and 9.2.7 don't change the database scheme.

I've upgraded from 9.2.6 to 9.2.7 - now without any error.
It means that warnings above are only due to incompatibility of 9.2.6-9.2.7 code with database tables prior to 9.2.6. Update process still needs post-upgrade handling.

@znaev, it IS reproducible, because it has been reproduced at least by 5 independent users. The fact that maintainers can't reproduce it means only one thing: that maintainers can't reproduce it.

Hello,
Could you give more details of how to reproduce the issue? What should we do to see the same error?
What PHP version, Drupal version, database version, any specific modules for the update process?
Waiting for your reply.

We are getting the same warnings as #29
PHP 8.1.13 and also on PHP 8.0.30
cleantalk 9.2.7

@joco_sp please contact us by our private Ticket System:
https://cleantalk.org/my/support/open

Dear customers

We have added a new feature, now you can send debug logs without having to provide access to your site.

Please install this version and send us the debug logs.

Hello.

Any updates on the issue?

@znaeff, what updates are you waiting for here when you have sent users to use your private ticket system?

A debug log with a record of the issue would be appreciated.

I am also seeing these same warnings and on the same lines as comment #29
Cleantalk 9.2.7
Drupal 10.1.3
PHP 8.1.18

Hello @mariodan,

Please install the special version from here:
https://www.drupal.org/project/cleantalk/issues/3383492#comment-15253807 🐛 Undefined array key Needs review

And send us the debug logs.

I have updated for this issue Undefined array key in the above attached patch.

Hello @Mohd Sahzad,

Please give us a few days to check this.

@znaeff,
i get it! i'd appreciate it if you could take a few days to review this. Feel free to reach out if you have questions or need more help. We're here for you.

Of course!

We've made some fixes. Please aplly the attached patch. Feedback will be very welcome.

Also getting a similar issue on core 10.1.5, PHP 8.1, Cleantalk 9.2.7. In my case, it's showing up in the logs as:

Warning: Undefined array key "next_call" in Cleantalk\Common\Cron\Cron->checkTasks() (line 255 of /app/web/modules/contrib/cleantalk/lib/Cleantalk/Common/Cron/Cron.php)

Will look if the patches work here.

Hello @karolus, please add below lines inside this checkTasks() function below code for removed Undefined array keys warnings

$task_data['handler'] = $task_data['handler'] ?? NULL;
$task_data['next_call'] = $task_data['next_call'] ?? NULL;
$task_data['period'] = $task_data['period'] ?? NULL;

@Mohd Sahzad: Where should this be added. I'm looking at the file, but it isn't exactly clear where to add the code. When I get confirmation of where to add it, I will create a patch, and post.

@karolus, please review patch 2 and apply it if it is working correctly.

karolus, Mohd Sahzad, our patch from here:
https://www.drupal.org/project/cleantalk/issues/3383492#comment-15279553 🐛 Undefined array key Needs review
does the same thing. The changes proposed by Mohd Sahzad will not be included in next release.

If this is not the case, please comment.

@znaeff, thank you—I've applied the patch, and tested in various environments. Looks like it has fixed the issue.

Hi @karolus, thank you for the feedback.

Also seeing this issue, will be happy to see it fixed so my cron logs are a bit cleaner :)

Hello geerlingguy.

Let me clarify. Have you applied the last patch and see the same stack trace as at the beginning of this issue?
If not, please write the details: what you see, under what conditions.

I have the same problem, but with undefined array key "processing"

I've already seen it with 9.2.7 on Drupal 9.5. Now, I have updated the site to 10.1.6, updated cleantalk to 9.3.0 + uninstalled and reinstalled the module - the log messages still appear on cron run

Hello,

We have fixed the issues and released a new version 9.3.0:
https://www.drupal.org/project/cleantalk/releases/9.3.0 →

Please, update the module and clear your website cache. Feedback will be appreciated.

agoradesign,

The error you specified is different. Please create a separate issue.
To solve the issue, please enable the "Collect debug data" option and send us the log when useful data appears there.

already done by another user, see 🐛 Undefined array key "processing" in Cleantalk\Common\Cron\Cron->checkTasks Active

If you can, please provide the logs because the reporter hasn't provided them yet.

chetan 11 → made their first commit to this issue’s fork.

chetan 11 → changed the visibility of the branch 3383492-1 to hidden.

chetan 11 → changed the visibility of the branch 3383492-1 to active.

So, undefined array key 'processing' was fixed - https://www.drupal.org/project/cleantalk/issues/3401908 🐛 Undefined array key "processing" in Cleantalk\Common\Cron\Cron->checkTasks Active
What about `undefined array key 'processing'` and other keys - we have changed the format for the cron tasks info store and these issues have appeared. However, the storage format comparison was implemented https://git.drupalcode.org/project/cleantalk/-/commit/8cd24663943c1cd84f...
For now, these issues should not occur anymore.

glomberg → closed merge request !26

Automatically closed - issue fixed for 2 weeks with no activity.