🇬🇧United Kingdom @Janner

I too think that this would be a great addition to the feature list of this module. It also feels like a natural and comfortable fit.

Would love to hear if anyone has managed to implement it?

After applying the patch I now only see the one warning message generated when viewing the format settings:

Warning: Undefined array key "#other_option" in Drupal\select_or_other\Element\ElementBase::addSelectField() (line 141 of /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php)
#0 /public_html/core/includes/bootstrap.inc(164): _drupal_error_handler_real(2, 'Undefined array...', '/...', 141)
#1 /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php(141): _drupal_error_handler(2, 'Undefined array...', '/...', 141)
#2 /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php(112): Drupal\select_or_other\Element\ElementBase::addSelectField(Array)
#3 /public_html/modules/contrib/select_or_other/src/Element/Select.php(20): Drupal\select_or_other\Element\ElementBase::processSelectOrOther(Array, Object(Drupal\Core\Form\FormState), Array)
#4 [internal function]: Drupal\select_or_other\Element\Select::processSelectOrOther(Array, Object(Drupal\Core\Form\FormState), Array)
#5 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1013): call_user_func_array(Array, Array)
#6 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#7 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#8 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#9 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(579): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#10 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#11 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(215): Drupal\Core\Form\FormBuilder->buildForm('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#12 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\views_ui\Form\Ajax\ViewsFormBase->Drupal\views_ui\Form\Ajax\{closure}()
#13 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(217): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#14 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(127): Drupal\views_ui\Form\Ajax\ViewsFormBase->ajaxFormWrapper('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#15 /public_html/core/modules/views_ui/src/Form/Ajax/Display.php(46): Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax')
#16 [internal function]: Drupal\views_ui\Form\Ajax\Display->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax', 'style_options')
#17 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#18 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#19 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#20 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#21 /vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#22 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#23 /public_html/modules/contrib/redirect_after_login/src/RedirectMiddleware.php(44): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /public_html/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Drupal\redirect_after_login\RedirectMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /public_html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /public_html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /public_html/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(209): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /public_html/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /public_html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /public_html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /public_html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /public_html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /public_html/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /public_html/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}

It appears that this may be a known issue with the current release of the Select (or other module: https://www.drupal.org/project/select_or_other/issues/3373641 🐛 Undefined array key "#other_option" Needs review

Posting this here as this appears to b related to the change introduced here and the Select (or other module.

In Views, when viewing the settings for the “Podcast RSS Feed” format settings, PHP errors are thrown.

This occurs if pointing the Copyright to a field or using the “Other” option to directly enter text.

Warning: Undefined array key "#type" in Drupal\podcast\Plugin\views\style\Rss->buildOptionsForm() (line 255 of /public_html/modules/contrib/podcast/src/Plugin/views/style/Rss.php)
#0 /public_html/core/includes/bootstrap.inc(164): _drupal_error_handler_real(2, 'Undefined array...', '/...', 255)
#1 /public_html/modules/contrib/podcast/src/Plugin/views/style/Rss.php(255): _drupal_error_handler(2, 'Undefined array...', '/...', 255)
#2 /public_html/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(1690): Drupal\podcast\Plugin\views\style\Rss->buildOptionsForm(Array, Object(Drupal\Core\Form\FormState))
#3 /public_html/core/modules/views/src/Plugin/views/display/PathPluginBase.php(437): Drupal\views\Plugin\views\display\DisplayPluginBase->buildOptionsForm(Array, Object(Drupal\Core\Form\FormState))
#4 /public_html/core/modules/views/src/Plugin/views/display/Feed.php(303): Drupal\views\Plugin\views\display\PathPluginBase->buildOptionsForm(Array, Object(Drupal\Core\Form\FormState))
#5 /public_html/core/modules/views_ui/src/Form/Ajax/Display.php(74): Drupal\views\Plugin\views\display\Feed->buildOptionsForm(Array, Object(Drupal\Core\Form\FormState))
#6 [internal function]: Drupal\views_ui\Form\Ajax\Display->buildForm(Array, Object(Drupal\Core\Form\FormState))
#7 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array(Array, Array)
#8 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(283): Drupal\Core\Form\FormBuilder->retrieveForm('views_ui_edit_d...', Object(Drupal\Core\Form\FormState))
#9 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(215): Drupal\Core\Form\FormBuilder->buildForm('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#10 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\views_ui\Form\Ajax\ViewsFormBase->Drupal\views_ui\Form\Ajax\{closure}()
#11 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(217): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#12 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(127): Drupal\views_ui\Form\Ajax\ViewsFormBase->ajaxFormWrapper('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#13 /public_html/core/modules/views_ui/src/Form/Ajax/Display.php(46): Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax')
#14 [internal function]: Drupal\views_ui\Form\Ajax\Display->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax', 'style_options')
#15 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#16 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#17 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#18 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#19 /vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#21/public_html/modules/contrib/redirect_after_login/src/RedirectMiddleware.php(44): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#22 /public_html/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Drupal\redirect_after_login\RedirectMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /public_html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /public_html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /public_html/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(209): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /public_html/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /public_html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /public_html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /public_html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /public_html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /public_html/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /public_html/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#33 {main}

Warning: Undefined array key "#other_option" in Drupal\select_or_other\Element\ElementBase::addSelectField() (line 141 of /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php)
#0 /public_html/core/includes/bootstrap.inc(164): _drupal_error_handler_real(2, 'Undefined array...', '/...', 141)
#1 /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php(141): _drupal_error_handler(2, 'Undefined array...', '/...', 141)
#2 /public_html/modules/contrib/select_or_other/src/Element/ElementBase.php(112): Drupal\select_or_other\Element\ElementBase::addSelectField(Array)
#3 /public_html/modules/contrib/select_or_other/src/Element/Select.php(20): Drupal\select_or_other\Element\ElementBase::processSelectOrOther(Array, Object(Drupal\Core\Form\FormState), Array)
#4 [internal function]: Drupal\select_or_other\Element\Select::processSelectOrOther(Array, Object(Drupal\Core\Form\FormState), Array)
#5 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1013): call_user_func_array(Array, Array)
#6 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#7 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#8 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#9 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(579): Drupal\Core\Form\FormBuilder->doBuildForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#10 /public_html/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('views_ui_edit_d...', Array, Object(Drupal\Core\Form\FormState))
#11 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(215): Drupal\Core\Form\FormBuilder->buildForm('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#12 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\views_ui\Form\Ajax\ViewsFormBase->Drupal\views_ui\Form\Ajax\{closure}()
#13 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(217): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#14 /public_html/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(127): Drupal\views_ui\Form\Ajax\ViewsFormBase->ajaxFormWrapper('Drupal\\views_ui...', Object(Drupal\Core\Form\FormState))
#15 /public_html/core/modules/views_ui/src/Form/Ajax/Display.php(46): Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax')
#16 [internal function]: Drupal\views_ui\Form\Ajax\Display->getForm(Object(Drupal\views_ui\ViewUI), 'feed_1', 'ajax', 'style_options')
#17 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#18 /public_html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#19 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#20 /public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#21 /vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#22 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#23 /public_html/modules/contrib/redirect_after_login/src/RedirectMiddleware.php(44): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /public_html/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Drupal\redirect_after_login\RedirectMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /public_html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /public_html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /public_html/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(209): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /public_html/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /public_html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /public_html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /public_html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /public_html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /public_html/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /public_html/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}

Drupal: 10.2.4
PHP: 8.1.27
Podcast (using Views): 8.x-1.9
Select (or other: 4.1.0

Adding the Accessibility tag as this issue has implications for screen reader users who can't see any text decoration that may indicate that a forum container is different to forums in the select field. As the screen reader announces the forum container as a selectable item, this leads to confusion and a poor user experience.

I appreciate that this issue is currently marked as postponed, but adding the tag for when the forum module is split off and issues start to be addressed again.

@mxh

Thank you for investigating this.

After patching with MR10 and clearing cache, the object/entity value is displayed as expected both when viewing the table of actions for a model and when editing an action.

Viewing, editing, and saving an action or model throws no error messages.

@jurgenhaas

Sadly I can't use the bpmn_io modeller due to it currently not being accessible to screen readers, so someone else will need to see if the same issue occurs with that too.

@DrupalBub

I'm actually wanting to migrate away from the Message Stack, which is what I currently use on the site I maintain. This is partly because it's overkill for my needs, but more importantly because it requires technical knowledge that I simply don't have.

The only reason I was able to get it working at all was thanks to a very detailed guide someone posted in the Message Subscribe issue queue. However, I'm concerned that changes in Drupal core or the Message Stack itself could break my notification system at any time. As someone without developer expertise, troubleshooting those kinds of issues in a timely manner would be extremely challenging.

My goal is to find a notification solution that better fits my limited technical skills and the basic requirements of my site. I'd like something simple and lightweight. A combination of the Flag and Rules module did this in the past. The ECA module has proved to be a great replacement for Rules in other areas, so I am hopeful that it can also be used in conjunction with Flag to create a comment notification system.

I need to make some changes to a couple of filters and am reluctant to so because of some of the reports in this thread - in particular @Olarin's experience of the formatting being stripped after separately installing 2 of the patches posted above.

Accordingly, would someone please confirm that the patch in #14 resolves the underlying problem and enables the subsequent editing of filters with no issues.

This would be with version 3.0.1 of the module.

Thanks

I'm looking to do the same as the OP, so was wondering if anyone has been successful in creating an ECA model that works with the Flag module to create a comment notification system?

Thanks for any pointers.

Janner → created an issue.

I'm also encountering this after updating to Drupal 10.20 from 10.17.

In my case I can't edit an existing field of type list select (text) or create a new field of this type.

I have the Field Permissions module enabled, so am assuming that this is the root cause as described above for me too.

@xamount

I got the error but am not using the LiteSpeed Cache module.

I've seen no instances of this error message since installing the patch yesterday.

It took longer than expected, but the error messages have now returned on an unpatched installation of 9.3.2.

I've now installed the patch and will report back tomorrow on whether the error messages persist.

@sah62 thank you for taking the time to investigate this and sharing a possible patch.

Since encountering this issue, version 9.3.2 of this module has been released. I installed this earlier today (updating from 9.2.7),and have yet to encounter this issue. As it was immediate and frequent when running 9.3.1, either 9.3.2 has resolved the issue or something else has.

If the issue doesn't resurface in the next day, I'll mark this as resolved as I appear to have been the only one to encounter this issue.

Have done so now: #40139

The error messages continue after completely uninstalling the module and then reinstalling 9.3.1.

I'm now back with 9.2.7 and not getting the error message.

Janner → created an issue.

It's now been more than a month since I first started seeing these error messages, and I'm still typically seeing in the region of 200 per day. This isn't on a particularly high traffic site.

This is far from ideal, as it makes it easy to overlook a PHP error that I might not want to overlook!

Attempting to use the Message multiple delete form (/admin/config/message/message_delete_multiple) throws a similar error, so it appears that the access check function may be a more widespread issue across the Messages module.

I *think* that this issue might be related to the following Drupal change record:

Access checking must be explicitly specified on content entity queries
https://www.drupal.org/node/3201242 →

Janner → created an issue.

To answer my own question, it's now been 10 days since an upgrade introduced this issue on my site. There's been no noticeable drop-off in the frequency and number of these messages in this time.

I too was encountering this issue after updating to 9.2.5.

I initially downgraded to 9.2.3 as a temporary ‘fix’. I then followed the suggestion above and uninstalled and reinstalled the module. Unlike others, this *appears* to have resolved the problem for me.

I'm experiencing this too after upgrading from 9.5.10 to 10.1.2 a couple of days ago.

For those of you who have been experiencing this longer and observed a decline in the frequency, did this pattern continue? Have the entries gone away completely yet?

Thanks!

Janner → created an issue.

@jurgenhaas

This is really helpful. Thank you!

I'll give this another shot this week.

Unfortunately, I have been unable to successfully implement this functionality. I have a view that utilizes filters and relationships to display users who have flagged a specific node, but I have been unable to determine how to use this view with my ECA model in order to generate an email recipient list. This is due to the limits of my own capabilities, and not those of ECA!

In the past, many Drupal 6 and 7 users(myself included( utilized a combination of the Rules and Flag modules to create comment notification systems, and I believe that ECA could be a great tool for achieving similar functionality now. For my own use case, the ability to easily utilise conditions and custom emails for different situations would offer a attractive alternative to other notification options currently available.

Accordingly, if anyone has been able to successfully implement an ECA model for this purpose, I would greatly appreciate it if you could share your solution here. This would not only benefit myself but also others who may be looking to implement the same functionality. Thank you.

@jurgenhaas

Thank you. I appreciate the pointers.

@jurgenhaas

That's really helpful and has got me closer, thank you!

Where I'm failing now is identifying how to correctly enter the argument for the desired contextual filter on the ECA Views: Execute query action.

On the view configuration page, the contextual filter is:

(Flags) Flagging: Entity ID

On the ECA action configuration page I've tried entering various tokens and text, but none appear to be correct. Looking at the logs, the ECA model is running and accessing the view. In fact, it's running a test successor to the Views: Execute query action.

I've looked at several models in the model library, but none of these used an argument for this action.

Would someone please offer some guidance on the correct way to enter the contextual filter in the Views: Execute query action?

Many thanks!

Janner → created an issue.

It is indeed the same.

I had not encountered this issue prior to the latest dev release.

However, I've only been performing some very limited testing of this module to date. Consequently, it may have been present or present in different places, but my testing hasn't triggered it before now.

After updating to the latest dev release, the content type edit page no longer throws the PHP error upon saving.

However, after allowing subscription for content type (in this case it was for the publish and comment events), navigating to an existing node of that content type now throws the following PHP error:


LogicException: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution. in Drupal\Core\Database\Connection->__sleep() (line 2042 of /public_html/core/lib/Drupal/Core/Database/Connection.php).


Since updating I have run drush updated and cleared the cache several times. The error persists.

Hello everyone, just a friendly reminder for those planning to implement this behavior. keep in mind that you may also want to exclude one-time login links and password reset links to ensure they continue to function properly.

Janner → created an issue.

Thanks for the clarification and explanation.

For some, the option to track DANSE notifications either via a tab on their profile page or via the dedicated RSS feed might suffice, in which case they wouldn't also want to receive email alerts. There might also be times when a user wants or needs to pause notifications.

All of that to say that offering users a simple toggle to enable/disable push notifications would be a great addition to this module in my opinion. I appreciate that this may fall outside your original vision for this module, but it would be great if you would consider adding this functionality.

Janner → created an issue.

I'm new to this module, so please excuse me if the following is expected behaviour...

I'm running the current dev release.

I have DANSE and DANSE content enabled.

On the DANSE settings for a content type, I select all of the “Create Content” options.

Doing so reveals a number of role selection lists.

For “Allow entity type subscription”, there are selection lists for Create, Update, and Delete.

For “Allow individual entity subscription”, there are selection lists for Update and Delete. (I understand why Create could not be an option here)

For “Allow related entity subscription”, there are selection lists for Create, Update, and Delete.

Consequently, I cannot select roles which can subscribe to the Publish, Unpublished, and Comment events.

This doesn't seem like it should be expected behaviour, particularly for my own desired use case would be to expose the Publish and Comment events as subscription options.

Note that on the current recommended release, where none of the ‘smart’ revealing/hiding of selection lists is implemented, I can select roles for my desired events and they appear to then behave as expected for allowing people to subscribe.

One of the concerns mentioned above is the possible implication for screen reader users. As one myself, I personally find the new behavior introduces no issues. In fact, having the selection lists hidden until they are usable offers a more intuitive and efficient experience.

Janner → created an issue.

@backelj

Thank you. It was the first of those permission settings which was the issue. Now set and working as desired.

@coxy0001

Sorry to revive an old thread, but I am encountering exactly the same behaviour as you describe in #8.

Did you ever resolve this? Or does anyone else have any suggestions?

It feels like it *must* be a permissions issue, but I'll be darned if I can figure it out.

As with #8, the tab only becomes visible to authenticated users if I enable the global permission to view any submission. Obviously this is not what I'm going to set!

Any thoughts and suggestions will be very much appreciated. Thanks!

It's not mentioned in the release notes, but this issue is resolved in version 9.2.3.

@znaeff

Thank you. After applying the patch I no longer see the PHP error messages.

@znaeff

Hi there, just wanted to follow up on this issue. Have you been able to successfully reproduce it yet? If not, please let me know if you require any additional information to assist you in your investigation.

Janner → created an issue.

I'm not encountering this issue after updating to 9.2.2.

Thank you for the speedy investigation and resolution. This module makes life so much simpler for me.

Janner → created an issue.