- Issue created by @jbaronmailbox@gmail.com
- Status changed to Needs review
over 1 year ago 8:46am 20 June 2023 - 🇨🇦Canada joseph.olstad
the patch I believe only has to do this to the twig, no need for the javascript changes.
templates/like-and-dislike-icons.html.twig
<div class="vote-widget vote-widget--like-and-dislike"> {% for type, icon in icons %} - <div class="vote-{{ type }} type-{{ entity_type }}" id="{{ type }}-container-{{ entity_type }}-{{ entity_id }}"> + <div class="vote-{{ type }} type-{{ entity_type }}" id="{{ type }}-container-{{ entity_type }}-{{ entity_id }}" {{ icon.attributes.setAttribute('tabindex', '0') }}> <a {{ icon.attributes }}>{{ icon.label }}</a> <span class="count">{{ icon.count }}</span> </div> {% endfor %}
- 🇨🇦Canada joseph.olstad
trying this instead, use space and enter key not just enter.
- 🇨🇦Canada joseph.olstad
patch #2, 5 and 7 do not activate the like/dislike on keypress enter or space.
Patch 8 activates keypress on space and enter key.
- Status changed to RTBC
over 1 year ago 5:19am 16 August 2023 - 🇨🇦Canada joseph.olstad
patch #8 does the trick for us.
feel free to suggest changes if you wish, with that said, this adds keyboard accessibility with the enter key and also space bar and a tab index also.
- 🇨🇦Canada joseph.olstad
This time the keyboard navigation works, all the previous patches had some sort of issue, now it's good.
-
adriancid →
committed 7dce6f4e on 8.x-1.x
Issue #3367864 by joseph.olstad, jbaronmailbox@gmail.com, adriancid:...
-
adriancid →
committed 7dce6f4e on 8.x-1.x
- Status changed to Fixed
9 months ago 5:25pm 13 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.