- Issue created by @eleonel
- @eleonel opened merge request.
- Status changed to Needs review
over 1 year ago 8:15pm 3 May 2023 - 🇯🇵Japan eleonel Itoshima 🇯🇵
I detached the CKeditor 4 functionality from the Augmentor module and I moved everything into a new submodule. Also I added an update_N hook to install this new
augmentor_ckeditor4
submodule to don't breack sites using it. - First commit to issue fork.
- 🇺🇸United States hyperlinked San Jose, CA
I've installed the issue fork and tested it to verify that Augmentor is able to work without requiring CKeditor 4 being invoked on the entity edit form. It works as expected both if there is no CKEditor at all on the form or if CKeditor 5 is enabled instead.
I've also made a couple of commits to this issue fork.
I moved the hook_update_N function into an *.install file in accordance to typical Drupal best practices.
I made enabling the augmentor_ckeditor4 module dependent upon having CKeditor 4 already installed to prevent users who do not want CKeditor 4 getting it enabled by accident. - Status changed to RTBC
over 1 year ago 12:03am 7 May 2023 - Status changed to Needs review
over 1 year ago 12:05am 7 May 2023 - 🇺🇸United States hyperlinked San Jose, CA
And requesting a review of my commit to change the hook_update_N processing.
-
eleonel →
committed aad3a75d on 1.0.x
Issue #3358019 by eleonel, hyperlinked: Separate Ckeditor 4 in a...
-
eleonel →
committed aad3a75d on 1.0.x
- Status changed to Fixed
over 1 year ago 2:50pm 9 May 2023 - 🇯🇵Japan eleonel Itoshima 🇯🇵
Thanks @hyperlinked, tested and merged.
- 🇮🇳India naveenvalecha New Delhi
Why are we keeping the obsolete files after moving?
- Assigned to eleonel
- Status changed to Needs review
over 1 year ago 6:10pm 9 May 2023 -
eleonel →
committed 6f7eeb1c on 1.0.x authored by
naveenvalecha →
Issue #3358019 by eleonel, naveenvalecha, hyperlinked: Separate Ckeditor...
-
eleonel →
committed 6f7eeb1c on 1.0.x authored by
naveenvalecha →
- Status changed to Fixed
over 1 year ago 8:22pm 9 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.