Contrib.social

Update throbber icon in Seven theme

Open on Drupal.org →
Created on 29 July 2016, over 8 years ago
Updated 31 May 2024, 6 months ago

Problem/Motivation

Original statement:

Need to build out the spinning circle throbber for use in autocomplete and ajax loading events based on the Proposal: A Style Guide for Seven.

Motivation is discussed in more detail in the style guide.

Proposed resolution

(To confirm: does this issue cover approving the new spinner into core? Or is this issue just about coming to some sort of agreement regarding the style guide element[s]?)

Replace the existing spinner with a preferred SVG version, falling back to a GIF for older browsers.

Testing instructions

The spinner is used on taxonomy fields (entity reference, taxonomy term), so from a clean install you can just add an Article node and check the tags field – see #9 for instructions on what CSS to change to keep it running continuously, and how to check the fallback animated GIF.

The spinner is also used is Place Blocks. From a clean Drupal install, enable the Place Blocks experimental core module. This will add a Place Block option (with a lego brick item) to the right of the toolbar. Click this and you'll get a screen where every region has a plus sign. The spinner is displayed when the plus icon is clicked.

Remaining tasks

1. Write/propose patch. (done: #9)
2. Trial patch. (done: #14)
3. Identify where the spinner is not being applied. (#17)
4. Re-roll/add to patch, in order to cover all instances where spinner is required.
5. RTBC patch.

User interface changes

Superficial, in line with the style guide.

API changes

n/a although patch as stands includes the Modernizr library in its assets.

Data model changes

None.

✨ Feature request
Status

Needs work

Version

1.0

Component
CSS  →

Last updated about 7 hours ago

Created by

🇨🇦Canada AaronChristian Kelowna, BC

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • JavaScript

    Affects the content, performance, or handling of Javascript.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 6 months ago →
    🇪🇨Ecuador jwilson3

    There was already an issue that was marked postponed on this one which IMO should be reactivated now that this one is no longer a blocker.

    It probably makes sense to have core maintainer (@laurii?) pull over issue credits from here to that issue, too.

    #1974928: Update throbber icon →

    Putting this into RTBC for maintainer visibility.

  • Comment 6 months ago →
    🇪🇨Ecuador jwilson3

    I put together a codepen to compare side-by-side before/after with a fairly close 1-to-1 (speed, color, size) though the style is slightly different, and modernized.

    https://codepen.io/jameswilson/pen/LYoZaXy

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇫🇷France nod_ Lille

    a 6 years old patch can't really be RTBC :) Please go through it, make sure it's still the right design, and put that in a MR

    It would help a lot for someone to go through the related issue and post the credits in a comment. I'll update the issue credit here

  • Comment 6 months ago →
    🇺🇸United States smustgrave

    Believe this belongs in the seven theme now.

  • Comment 6 months ago →
    🇪🇨Ecuador jwilson3

    It would help a lot for someone to go through the related issue and post the credits in a comment. I'll update the issue credit here

    The idea is to pull over credit from everyone who worked on this issue into the older original one that is still open in Drupal core's issue queue: #1974928: Update Drupal's default throbber icons → .

    Please go through it, make sure it's still the right design, and put that in a MR

    .

    I've already done this on the other issue which now has an MR.

    The design changes proposed here would be something that remains scoped to the Seven theme only. I'm not certain that makes any sense to be evolving now that Seven theme is removed from core. Assuming maintainers of Seven think this has any chance of getting in, and still want this in an MR, then it may be easiest to just copy over the MR approach from that core issue here for Seven. It could use one of the two SVGs proposed on that issue (see the codepen in that issue's summary for reference).

    I'm leaving this in NW to:

  • Comment 6 months ago →
    🇫🇷France nod_ Lille

    thanks for the work on the other issue. I didn't realize this one was related to seven

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024