Update throbber icon

There was already an issue that was marked postponed on this one which IMO should be reactivated now that this one is no longer a blocker.

It probably makes sense to have core maintainer (@laurii?) pull over issue credits from here to that issue, too.

#1974928: Update throbber icon →

Putting this into RTBC for maintainer visibility.

I put together a codepen to compare side-by-side before/after with a fairly close 1-to-1 (speed, color, size) though the style is slightly different, and modernized.

https://codepen.io/jameswilson/pen/LYoZaXy

a 6 years old patch can't really be RTBC :) Please go through it, make sure it's still the right design, and put that in a MR

It would help a lot for someone to go through the related issue and post the credits in a comment. I'll update the issue credit here

Believe this belongs in the seven theme now.

It would help a lot for someone to go through the related issue and post the credits in a comment. I'll update the issue credit here

The idea is to pull over credit from everyone who worked on this issue into the older original one that is still open in Drupal core's issue queue: #1974928: Update Drupal's default throbber icons → .

Please go through it, make sure it's still the right design, and put that in a MR

.

I've already done this on the other issue which now has an MR.

The design changes proposed here would be something that remains scoped to the Seven theme only. I'm not certain that makes any sense to be evolving now that Seven theme is removed from core. Assuming maintainers of Seven think this has any chance of getting in, and still want this in an MR, then it may be easiest to just copy over the MR approach from that core issue here for Seven. It could use one of the two SVGs proposed on that issue (see the codepen in that issue's summary for reference).

I'm leaving this in NW to:

• get Seven theme maintainer feedback on issue validity
• convert this issue into an MR
• review all contributors on this issue and make a list of them on #1974928: Update Drupal's default throbber icons → so core maintainer can add credit there

thanks for the work on the other issue. I didn't realize this one was related to seven

Modenizr has been deprecated in Drupal core ( 📌 Deprecate Modernizr Fixed ); any usage has been removed from Drupal core ( #3281559: Remove modernizr usages from core → ).

We should not rely on that library.

I suggest starting over with a clean MR that just pulls in the SVG throbber that ended up getting committed to Core in #1974928: Update Drupal's default throbber icons → using the same approach from that issue for the Seven theme. No modernizer needed.

Was about to pick this up, but neither throbber-active.gif nor throbber-inactive.png from core have been copied into the seven theme, meaning it inherits whatever core has already.

The only icon I see in the seven theme codebase is https://git.drupalcode.org/project/seven/-/blob/2.0.x/images/loading-sma... referenced only by jQuery UI Dialog.

https://git.drupalcode.org/project/seven/-/blob/2.0.x/css/components/dia...

The loading-small.gif is out of scope of this issue, therefore, I suggest closing this one and opening a follow-up issue to pull down the animated SVG I did for core in 📌 Update loading icon and use SVG Needs review .

I would like to get a new throbber in Seven, but as SVG image like Drupal core does.

Why not just inherit the one from Drupal core?

I feel, like aaronchristian and others who worked on this issue, that the proposed throbber fits better the theme styles.

This issue is not just about replacing the throbber with a SVG image, but also giving a new one to the Seven theme.

I am closing this issue since, despite the issue summary, its patches update the Drupal core throbber, not only the Seven theme's one.

As there has not been progress in about six years, I am now inclined to use the default Drupal throbber.

Amending attribution.