Account created on 1 December 2022, almost 2 years ago
#

Merge Requests

More

Recent comments

πŸ‡΅πŸ‡±Poland dolszewski

Hello @kwfinken

I don't see font size in the contrib module you referenced in the issue. Only FontColor and FontBackgroundColor.

However, https://ckeditor.com/docs/ckeditor5/latest/features/font.html#configurin... according to this docs
CKEditor5 doesn't allow the specification of units other than px.

There is an open GitHub issue in the CKEditor5 repository about adding different units. https://github.com/ckeditor/ckeditor5/issues/2295

πŸ‡΅πŸ‡±Poland dolszewski

@vipul-tulse

Can you provide the source of information that in the 10.3.0 list styles are included?
In the core source, you can see that styles are disabled: https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/cke...

πŸ‡΅πŸ‡±Poland dolszewski

@vipul-tulse

Find and replace will not work in that way as shown in the video. The find and replace modal is linked to the editor where it was triggered. In case the video is linked to the editor from tab1, you have to click the toolbar icon on the editor in tab2 to use it in the second editor.

πŸ‡΅πŸ‡±Poland dolszewski

@jayzee

Highlight plugin uses classes to apply styles. You must add these styles to your theme to be displayed on the node page. They are listed in the config form.

See docs:
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... β†’

πŸ‡΅πŸ‡±Poland dolszewski

Hello @vipul-tulse

I have added MR, which adds the possibility of choosing UI type to find and replace. It is available in text format edit form.

Also, can you provide more information on what issue you are facing when two or more editors are present on one page? I have checked find and replace with multiple editors on one page and everything was working fine.

πŸ‡΅πŸ‡±Poland dolszewski

dolszewski β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @vipul-tulse

Have you used other contrib module for lists before? In the plugin pack, we don't change any configuration related to lists so I'm not sure if this is caused by plugin pack module.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @sstapleton
I have a few questions. Did you try unselecting and selecting "Limit allowed HTML tags and correct faulty HTML"? I noticed that if you have selected that filter in text format and a new plugin is added, the new allowed tags are not added.
Also, can you confirm that in the editor in the source code classes are added to the block indention? If not, please reinstall CKEditor 5 Block Indentation plugin.

Unfortunately, we can't do anything with font color at this moment. You can use the Highlight plugin to achieve the same result as in the color font plugin.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @ryanrobinson_wlu
We added Block Indent by class in the newest release (1.2.1). Please check if it works for you.

πŸ‡΅πŸ‡±Poland dolszewski

Closing this issue as outdated, in the 1.2.0 release, the `routing.yml` file is used for the configuration form.

πŸ‡΅πŸ‡±Poland dolszewski

@goz
Patch has been added to the newest release (1.2.0). Thank you for your contribution.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @SergeyShadrin thank you for your contribution.
In the latest release (1.2.0) we have added your changes. I made some improvements to keep the same convention that we have in premium features.

πŸ‡΅πŸ‡±Poland dolszewski

The latest release (1.2.0) contains changes from the MR made by @salmonek.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @goz
Thank you for providing a patch. It looks good, we will add it in the next release.

πŸ‡΅πŸ‡±Poland dolszewski

@chris@chrislavigne.com
On the demo page, there is the editor instance like in the node edit form in Drupal where checkboxes are also not disabled.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @damienmckenna

I've added a patch for this issue. It will not fix the problem completely but the

tag with class should not be removed anymore (probably you have to unselect and select again the "Limit allowed HTML tags and correct faulty HTML" filter.
In terms of style attributes, we can't do anything with that, Drupal does not allow adding style attributes ( https://www.drupal.org/project/drupal/issues/3381471 ✨ CKEditor 5: Restricting the style attribute in tag has restricted some modules to work as expected. Closed: works as designed ).
Any suggestion on how to change the style attribute into something else in the ckeditor5 page break plugin should be added to the official ckeditor5 repo on GitHub.
πŸ‡΅πŸ‡±Poland dolszewski

@endless_wander
Yes, this is a workaround solution, To-Do List is a plugin provided by the core of CKEditor5, we only implement it in Drupal, so we can't easily change how it behaves, your proposed changes should be added to the official ckeditor5 repo on GitHub.

πŸ‡΅πŸ‡±Poland dolszewski

@damienmckenna
I had that error when I applied your patch, so it is related to this issue.
On Drupal 10.2 I can save text format but on 10.3 it doesn't work.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @damienmckenna
In Drupal 10.3 I can't submit a Text Format form. I have an error:

Error message
'node' is not a supported key.
'file' is not a supported key.
'media' is not a supported key.
'taxonomy_term' is not a supported key.
'user' is not a supported key.

Possible it is a similar case as in the shortcode module: https://www.drupal.org/project/shortcode/issues/3457731 πŸ› Unable to save text format config form in 10.3 Fixed

πŸ‡΅πŸ‡±Poland dolszewski

hello @endless_wander
I've added MR with a new filter which will remove the disabled attribute from to-do list (it will be present in the text format edit form in the section Enabled filters). Please check if it works for your case.

πŸ‡΅πŸ‡±Poland dolszewski

dolszewski β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @jons
We already have a related issue for that warning (originally reported for highlight but the same warning is present in text transformation and font color).
Please check this issue and the patch attached there: https://www.drupal.org/project/ckeditor5_plugin_pack/issues/3459095 πŸ› foreach() argument must be of type array|object, null given in Drupal\ckeditor5_plugin_pack_highlight\ RTBC

πŸ‡΅πŸ‡±Poland dolszewski

@noonoos Thank you for providing more information.

Have you tried maybe creating a new text format with only the font plugin enabled and see if an error occurs then as well?

πŸ‡΅πŸ‡±Poland dolszewski

Hi @noonoos
Can you also provide your text format configuration file?

πŸ‡΅πŸ‡±Poland dolszewski

Closing the issue. As a reference: https://www.drupal.org/project/drupal/issues/3381471 ✨ CKEditor 5: Restricting the style attribute in tag has restricted some modules to work as expected. Closed: works as designed

πŸ‡΅πŸ‡±Poland dolszewski

I can reproduce this error without the Plugin Pack module.
I checked it (without Plugin Pack) on Drupal 10.2 and it is working (no errors) but after upgrading to Drupal 10.3 error from the issue is occurring.
@vincent.hoehn can you uninstall the plugin pack and check again on Drupal 10.3 if the error is present?

πŸ‡΅πŸ‡±Poland dolszewski

@abhishek_gupta1 Thank you for MR, I have added comments to it.

Also added a new MR with changes in Font Color and Text transformation, because the same warning occurs there:
https://git.drupalcode.org/project/ckeditor5_plugin_pack/-/merge_requests/5

@tjtj
Added patch file to the issue

πŸ‡΅πŸ‡±Poland dolszewski

Hi @radheymkumar
Thank you for reporting the issue
We will remove it in the next release.

πŸ‡΅πŸ‡±Poland dolszewski

@scott_euser
Thank you for the MR. I checked it and it looks good!
We will include that change in the next release

πŸ‡΅πŸ‡±Poland dolszewski

@scott_euser Can you check again? I forgot to update the library version maybe that was the problem.
If an error still occurs, the problem's source is in different places. Do you use a custom admin theme or anything that changes node form?

πŸ‡΅πŸ‡±Poland dolszewski

Hello @scott_euser
Thank you for reporting the issue. There is a problem with the missing container while reloading the form with Ajax.
I've added a patch, please check it.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @scott_euser
Thank you for reporting the issue. I've added a patch, please check it.

πŸ‡΅πŸ‡±Poland dolszewski

dolszewski β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @thomas-kaisuka
This error is related to Premium Features module. There is already a patch for this:
https://www.drupal.org/project/ckeditor5_premium_features/issues/3455574 πŸ› plugincollection-plugin-not-loaded when upgraded to 1.2.9 Active

πŸ‡΅πŸ‡±Poland dolszewski

Hi @endless_wander
Thank you for reporting the issue.
I have added an MR to the issue with a fix.
Please check it.

πŸ‡΅πŸ‡±Poland dolszewski

The latest release (1.1.0) contains a fix for that bug.

πŸ‡΅πŸ‡±Poland dolszewski

The latest release (1.1.0) contains a fix for that bug.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @jons
Do you have enabled "Limit allowed HTML tags and correct faulty HTML" filter in your full_html text format? I assume that could be the reason why attributes are stripped out.

πŸ‡΅πŸ‡±Poland dolszewski

@anouar-louedziane
Thank you for the information. It looks like the problem occurs only in Drupal 10.1. A similar error shows with the Text Transformation plugin. I have added a patch for errors in word count and text transformation if someone needs it. You can check my patch if you like.
We will include the fixes in the next release.
Thanks again for reporting this error.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @anouar-louedziane
Thank you for reporting the issue.
Can you provide more information about your Drupal instance and the steps to reproduce the error? In the clean Drupal 10 instance I can't reproduce this error.
From the error stack, I can see that you use layout builder and contrib module Autosave Form. Do you use more contrib modules that work with CKEditor 5?
Because it looks like a compatibility problem with contrib module I change the priority to Normal.

πŸ‡΅πŸ‡±Poland dolszewski

@justcaldwell
Ah sorry, I missed that you have installed a premium feautres productivity pack. You cannot have both installed at the same time in that case. When you install a premium features productivity pack, it overrides the "plugin pack template" plugin config and you need to have a license key for the productivity pack.
You have that fatal error because my patch only works for the plugin pack (the same error occurs in premium features). Of course, we will also add patches for premium features before Drupal 10.3 is released.
Please check it without the premium features productivity pack installed.

πŸ‡΅πŸ‡±Poland dolszewski

Hi @justcaldwell
I have posted MR with the fix, feel free to test it. We will also test it internally.
Recently, in 10.3-dev some changes were made in the ckeditor5 core module that caused this fatal error.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @duckydan
We will need more information about your issue.
What do you mean by "all the ckeditor instance on the page"? Do you have multiple fields with the editor on the node edit page?
Which version of Drupal do you use?
Can you send some screenshots and errors from the console?
Do you use any other contrib module for ckeditor5?

πŸ‡΅πŸ‡±Poland dolszewski

Added url to the project page

πŸ‡΅πŸ‡±Poland dolszewski

The issue was fixed in version 1.2.4

πŸ‡΅πŸ‡±Poland dolszewski

@wim-leers
I have added config files to the issue.

Sample markup:
<img src="https://www.drupal.org/files/docs/user_guide/en/images/coverimage.png" alt="TEST" data-caption="some text">

πŸ‡΅πŸ‡±Poland dolszewski

dolszewski β†’ created an issue.

πŸ‡΅πŸ‡±Poland dolszewski

Hello @c-s-comfort

Productivity Pack will be included right after Drupal 10.1.0 release which is planned for June 21.

Production build 0.71.5 2024