Page break plugin looses formatting when editing content

I suspect the problem is that the "Limit allowed HTML tags and correct faulty HTML" filter removes the HTML structure that the plugin creates.

I think this will be another scenario where core's "Limit allowed HTML tags and correct faulty HTML" filter always removes the "style" attribute, due to its security implications. The Extended HTML Filter → module aims to replace core's filter with one that allows the "style" attribute, but it has problems, see ✨ Match the filter_html <> ckeditor5 integration in Drupal core Needs work for details.

FYI I suspect other plugins might also be affected by this.

Hi @damienmckenna

I've added a patch for this issue. It will not fix the problem completely but the

I think the best way forward would be to put some time into Extended HTML Filter → and make it a required dependency for the submodules that require the "style" attribute.

I tested patch #4 but it doesn't retain the "class" attribute, something is removing it. I think the definition also needs an entry for the span tag.

Thanks @DamienMcKenna, followed your rabbit hole of related issues. At the moment its a house of cards of patches to get this to work it seems. Most of the patches actually do no harm getting in, and facilitate things working once other bits get merged. I think in summary:

1. Allow div class and span attributes - ckeditor5_plugin_pack module - 💬 Page break plugin looses formatting when editing content Needs work - ie, this issue, your patch in #7. Ready to merge I think
2. Fix validation constraint so that * actually does not complain about diffs - drupal core - ✨ Match the filter_html <> ckeditor5 integration in Drupal core Needs work comment #17 but has no actual core issue. Workaround is to save the config manually
3. Make extended html module match drupal core - extended_html_filter - ✨ Match the filter_html <> ckeditor5 integration in Drupal core Needs work - Probably ready to merge there, but again requires workaround until (2) is fixed.
4. <* style> is not accepted - drupal core - 🐛 FilterHtml accepts <*> but does not support it, resulting in inaccurate ::getHtmlRestrictions() return value Needs work - Not yet ready to merge but contributed to by multiple core maintainers, so we can be confident its going in the right direction at least and has a viable path to merge

So based on that, probably merging this one (1) and merging (3) do no harm and at least would prep these two modules for when core actually supports it, making it easier for people to use things like page breaks without all of the above steps. Do you agree? If so, I'll mark this as RTBC for ckeditor5_plugin_pack maintainers to review.

Thanks for digging into it, Scott. Yes, this is definitely a layered problem and bugs in core are affecting it.

Okay I suggest we merge this one given it does no harm and once other related issues get fixed and merged we will eventually have working page breaks :)

This was partially added in the new 1.2.x branch, but it missed the SPAN tag change from #7.

Dear maintainers,
Please work with the issue queue instead of committing changes elsewhere and then pushing the repository to d.o. Thank you.

The fix has been released in previous (1.2.2) release.
Thank you for the contribution.

@damienmckenna
We're using company repositories for tickets requested by management and bugs reported by QA since people across organization have access there and are familiar with it. In this module we will operate more on Drupal repositories as the internally induced work is mostly done.