- Issue created by @scott_euser
- 🇬🇧United Kingdom scott_euser
Okay merge request created:
- NestedArray::getValue already checks key exists (or in fact keyExists method actually calls getValue so this reduces a lot of overhead by not doing the same thing twice given we are comparing many arrays with an array
- Drastically lower the depth to travel; the argument for it was for Gin, but Gin's depth is not 10 levels deep: https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/src/GinContentForm...
- Status changed to Needs review
5 months ago 12:33pm 26 June 2024 - Status changed to RTBC
5 months ago 3:15pm 3 July 2024 - 🇵🇱Poland dolszewski
@scott_euser
Thank you for the MR. I checked it and it looks good!
We will include that change in the next release - Status changed to Fixed
4 months ago 10:30am 31 July 2024 - 🇵🇱Poland salmonek
@scott_euser We have released 1.3.0 with your patch. Thank you for the contribution.
- 🇬🇧United Kingdom scott_euser
Great thanks for taking care of it (and the other issues you released!). Much appreciated
Automatically closed - issue fixed for 2 weeks with no activity.