[drupalMedia] [drupalImage] Make image title attribute configurable

I also added the functionality to drupalImage, for me everything is working pretty good, please review my changes in the 3380223-mediainsert---make branch :-)

Whats still open is that the allowed_html changes by adding the title attribute, i´m not sure how to update this and need help whats the best way to do so. Also, as this functionality is missing in ckeditor5 library it might make sense to port it there.

Opened the MR so it may reviewed.

Have not reviewed it myself but something like this I can see will need test coverage.

Thanks

Hey @smustgrave, thanks for your reply. Surely i will update/adjust the tests for media to also check for the functionality, but i´d say before that the actual code change should be reviewed and in this process probably further developed. It´s the first time I try to contribute something to core, especially using MR´s so please go easy on me :) I actually dont know why the branch is currently not mergeable, i dont know where i find any output about it. But yes i´d love to write the tests as soon as the feature is finalized.

One thought i have is if there should be a default text for the title attribute, maybe it makes sense to use the text-alternative? Ideally this would be configurable, on most of our systems, in example, medias have a title field with a designated title additionally to the text-alternative. This could possibly be a setting within the media tab in text-format edit page?

@sascha_meissner Thanks for working on this. The merge is blocked because there are new commits on 10.1.x and your branch has diverged, so a fast-forward merge is not possible. To fix this, you need to rebase the MR branch. You can see this when you open the MR page in GitLab:

> Merge blocked: fast-forward merge is not possible. To merge this request, first rebase locally.

See here for more info: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

To get an early review or a second opinion for design decisions, you could ask in #ckeditor5 or #contribute in Drupal Slack.

It´s been some time ... just rebased origin/10.1.x into my issue fork (which was a little nasty because i needed to rebuild ckeditor5 for every commit :P ) Also didnt manage yet to join the slack or do any other progress related to the topic, at least you can patch 10.1.8 now with the diff

Epic work here! 👏

1. This is modifying DrupalInsertImage too? Would this title be more accurate? Can you update the issue summary to explain why we should modify both simultaneously in this issue?
2. Also: I recall that the title attribute can be problematic wrt its impact on accessibility. Can you also explain in the issue summary why this would not be a concern?
3. Finally: I see no test additions nor changes 😅 There is a lot of test coverage for related functionality, expanding test coverage should be relatively straightforward.

@wim-leers

Thank you for also putting efforts into this, it´s been some time and we finally convinced our customer and their seo-agents to drop this feature due to the already mentioned lack of cross-plattform a11y (Even though i personally also like this as a desktop user) IMHO this should be an option, but not provided by the drupal implementation, rather shipped with CKE.

I´ll close this for now