🇮🇳India @adwivedi008

Hello @charlliequadros
I was already working on the issue
I have updated the MR and tried to implement the suggested changes
Please review and let me know if we require any other changes

Moving the issue to needs review

adwivedi008 → created an issue.

adwivedi008 → changed the visibility of the branch 3516363-make-message-configurable to active.

adwivedi008 → changed the visibility of the branch 3516363-make-message-configurable to hidden.

adwivedi008 → made their first commit to this issue’s fork.

Hello @asheesh

I tried applying your patch provided for branch 3.0.x, but it seems that it is making changes that are already fixed in the branch

I again tested and fixedthe automated issues using
phpcbf --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

Please review and suggest if any other changes are required moving the issue to RTBC and lets wait for some more feedback

adwivedi008 → made their first commit to this issue’s fork.

Hello @ggh

As I can see, there are more than 100 changes in the MR affecting more than 100 files

It's better to take limited files instead of affecting all files at a go, and if we are going all files in a go, then we should only fix the automated issues first and then open another issue for the other fixes

Moving the issue to needs work

Hello @Kul.pratap

I have tested the MR-62 and can confirm this is fixing the issue and providing the title search feature

Attaching screenshot for reference and moving the issue to RTBC

Hello @paraderojether

I have tested the Mr using the following command

phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

and found only two open issues, which can be ignored. The rest all is fixed

FILE: menu_position/src/Form/MenuPositionRuleForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 250 | WARNING | Unused variable $menu_name.
 303 | WARNING | Unused variable $menu_link.
----------------------------------------------------------------------

Moving the issue to RTBC, and let's wait for some more feedback

Thankyou

Hello @everyone
I also tried to change the title using git (by changing the commit message ), but sadly, that is not working, and I don't have access to change it directly at MR

Hello @prudloff

I have updated the doc block with the provided suggestion
Please review and suggest if any other changes are required
Moving the issue to Need Review

adwivedi008 → changed the visibility of the branch 3515406-wrong-return-type to active.

adwivedi008 → changed the visibility of the branch 3515406-wrong-return-type to hidden.

adwivedi008 → made their first commit to this issue’s fork.

adwivedi008 → changed the visibility of the branch 3505292-duplicate-alias-generation to active.

adwivedi008 → changed the visibility of the branch 3505292-duplicate-alias-generation to hidden.

Hello @dsdeiz I have converted your patch to Mr and have tested it,
It is working fine now

moving the issue to RTBC and lets wait for some more feedbacks

adwivedi008 → made their first commit to this issue’s fork.

Hello @GGH

I have checked the error reported by PHPCS and have applied automated fixes

It still needs work as some of the issues remaining

Please review and suggest if any other changes are required
I have tested using the following command

phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

adwivedi008 → made their first commit to this issue’s fork.

Hello GGH

I have reviewed the MR and it seems fine to me
moving the issue to RTBC and lets wait for some more feedback

Hello @andypost

I have tested the branch 3,0,x in my local and it seems working fine

Can we have a list of remaining tasks here or if it is ready can we have a alpha/ beta release available

adwivedi008 → made their first commit to this issue’s fork.

Hello Smustgrave,

Can you explain a bit what other changes are required over the Mr because as per comment the changes are not very clear to me

Do we need to remove the typedConfigManager completely? Or anything else

The 'This method is no longer used by Drupal core' is redundant here and can be removed.
Also I think the replacement is to use the typeConfigManager property as is done in ::validateForm()

Hello @jquijano,

I have checked the changes and it looks good to me
Also, there is no merge conflict as you already rebased the branch

Seems good to me, moving the issue to RTBC and let's wait for somemore feedback

I was also facing the issue and can confirm MR12 fixes the issue

Hello @lavanyatalwar,
I have tested your changes over the theme and it seems its fine and working as expected

moving the issue to RTBC and lets wait for some more feedback

adwivedi008 → made their first commit to this issue’s fork.

Hello @charlliequadros

I tried to update the deprication message by following the instructions
Please review and suggest if any other changes are required

Also, the change record needs to be created.

adwivedi008 → made their first commit to this issue’s fork.

Hello brandonlira

I have reviewed the MR and it seems that it is resolving the issues
Also can you please share the steps to test and lets wait for somemore feedback

Moving the issue to RTBC

Hello @charlliequadros
I have checked the MR and it seems that the suggested changes have been implemented

Moving the issue to RTBC and let's wait for some more feedback from @alexpott or @longwave,

Hello @koustav_mondal
Ihave checked the MR note and it seems that the suggested changes have been implemented

Moving the issue to RTBC and lets wait for some more feedbacks

Hello Jonasanne

I have reviewed your MR and it seems that it is removing the dependency from composer.json

Moving the issue to RTBC and wait if others to review

Hello ankitv18

As per suggestions, I have rebased the branch with 2.x

Please review and suggest any other changes required

adwivedi008 → made their first commit to this issue’s fork.

Hello Shweta

I have tested the MR and it seems that it is resolving the issue

Moving the issue to RTBC

Hello @Doxigo,

I have added a few checks for preventing errors, and also added the exception handling for the errors provided

Please review and suggest any other changes required

Moving the issue to needs review

adwivedi008 → made their first commit to this issue’s fork.

The changes seem fine to me and are working as expected

However, I have tested the changes based on the MR, as the Steps to reproduce are missing

Moving the issue to RTBC, and also appreciate if we add steps to reproduce

Adding tag "Needs steps to reproduce" so that we have some more RTBC before moving forward with it

As the Status of the issue was RTBC before merge conflict, I guess @sivaji has only made a merge to resolve conflict

The MR seems fine to me
Moving its status back to RTBC and let's wait for some more RTBC, then move forward with the changes

Hello @adamps

I have implemented the suggestion provided for extending support to PHP 8.4.

Please review and suggest any other changes is required

Moving the issue to Needs Review

adwivedi008 → made their first commit to this issue’s fork.

Hello @ankitv18

I have tested the MR on D-11 and it is working as expected the module settings page is working fine

I also checked the MR and there are some comments added on MR by you if they are resolved then mark them as resolved

If the issue is for different Drupal versions then maintainers can create 2 different releases for different versions

Moving the issue to RTBC

Hello Undersound3 and Everyone
I was checking out for an edit link and that was neither looking good nor handly
That's why I thought it would be better if we use operational links here instead of an edit link

I have modified the MR accordingly
Please review and suggest any other changes required

I have added screenshots for both

adwivedi008 → made their first commit to this issue’s fork.

Hello @Joachim
Have updated the documentation according to the provided description

Please review and suggest any other changes required

adwivedi008 → made their first commit to this issue’s fork.

Hello @quietone

I have added the recommended changes
Please review and suggest any other changes required

adwivedi008 → made their first commit to this issue’s fork.

Fixed the issues reported by Drupal coding standards

Please review and let me know if any other changes are required

adwivedi008 → created an issue.

Hello @arturopanetta

Created the MR with the fix for the issue
Please review and let me know if any other changes are needed

Moving the issue to needs review

adwivedi008 → made their first commit to this issue’s fork.

Hi @xmacinfo

Created the MR with the proposed solution
Please review and let me know if any other changes are needed

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to active.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to hidden.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to active.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to hidden.

adwivedi008 → made their first commit to this issue’s fork.

Hello @nod

Can you please suggest what other changes are needed on this
Or do we need to create another issue related to this for cleanup

Hello @daniel

I have taken a look at MR and it seems to be correct

Moving the issue at RTBC
Thank You let's wait for some more feedbacks

Hello @hondaman900
The module is originally developed for D8 or higher version

If you still want to modify your can create a feature request and raise a MR, would love to merge and release for D7 too

adwivedi008 → made their first commit to this issue’s fork.

@joachim I have updated the readme file with the comments and the settings
Please review and merge

adwivedi008 → made their first commit to this issue’s fork.

@smust grave I have updated the MR according to the suggested changes
Please review

adwivedi008 → made their first commit to this issue’s fork.

MR 61 seems fine to me
tested on vanilla Drupal and now buttons are translatable
Moving the issue to RTBC

@dhruv.mittal
Can you please check again, the MR against which version you are creating the MR I guess it should be created against 4.0.x and the branch should also be taken from 4.0.x
Moving this issue to Needs work as there are more than 200 commits in MR

Updated the dependency as per the issue description comments
Please review

adwivedi008 → made their first commit to this issue’s fork.

Reverted the out-of-scope changes.
please review

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

Is there any update on this issue? This is an issue if we are using Ajax and a better-exposed filter together

Any workaround would also be appreciated

Is there any update on this issue? This is an issue if we are using Ajax and a better-exposed filter together

Any workaround would also be appreciated

The issue has been fixed and resolved

Thanks @bhaveshdas and @prem

Moving the issue to fixed

Test the MR-8 changes with CKE-5 and Drupal-10 and its working fine as the feature is expected

Moving the issue to RTBC

Merged D-11 related changes

Hi everyone, Thanks for working on the issue
Can someone create a merge request with the latest changes

I am facing the same issue and patch #50 doesn't seem to resolve the issue for D-10.2.6
any suggestions

@rveillard Do you find any solution for this
I am also getting the same issue for video component

@jochim updated the MR as per your suggestions
Apology for the bulk changes as I get confused about bringing the whole doc changes vs only document part changes

Moving the issue to needs review.

@joachim
I have updated the documentation using https://www.drupal.org/files/issues/2020-05-29/3040427-37-migrate_plus_m... →
and https://www.drupal.org/files/issues/2020-05-17/3040427-32-migrate_plus_m... → as reference as you have mentioned in #5

Closed MR of #7 as that was not correct and was opened by mistake apology for that

Please review the changes and inform if any other changes are required

adwivedi008 → made their first commit to this issue’s fork.

Hi everyone,

I want to work on this issue can someone guide me to which section can we add the module and remove from core

Created MR for all the issues raised over coding standard command
Checked using the following command.
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml ./

Moving the issue to Needs Review

adwivedi008 → made their first commit to this issue’s fork.

Verified the changes mentioned on MR-7857
The padding is 12px 16px over the menu items child

Attaching a screenshot as a reference

Moving the issue to RTBC

RTBC++