[Svelte] Remove special-casing of the 'categories' filter

Created on 5 March 2025, 5 months ago

Problem/Motivation

So the Svelte code handles filters generically now...well, almost. It's not quite true. There are still several places, largely in Search.svelte and MultipleChoiceFilter.svelte, where we are special-casing the categories filter.

Proposed resolution

Let's fix this.

The real challenge here is the FilterApplied component, which is used to show the currently selected categories. To make that generic, we probably want it to just be a "lozenge cloud" of all terms selected from all multiple choice filters. Removing lozenges should unset the corresponding values in the corresponding filters.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Pipeline finished with Success
    5 months ago
    Total: 649s
    #440348
  • 🇺🇸United States phenaproxima Massachusetts
  • 🇮🇳India adwivedi008

    The changes seem fine to me and are working as expected

    However, I have tested the changes based on the MR, as the Steps to reproduce are missing

    Moving the issue to RTBC, and also appreciate if we add steps to reproduce

    Adding tag "Needs steps to reproduce" so that we have some more RTBC before moving forward with it

  • 🇺🇸United States phenaproxima Massachusetts

    There's no way to "reproduce" this -- it's not truly a bug, it's just some old code that needs refactoring. :) Removing the tag.

  • 🇺🇸United States phenaproxima Massachusetts
  • 🇮🇳India utkarsh_33

    The changes looks good to me and the filters are also working correctly.Marking it RTBC'd.

  • Pipeline finished with Success
    5 months ago
    Total: 364s
    #441023
  • 🇺🇸United States tim.plunkett Philadelphia

    Saving credit

  • Pipeline finished with Failed
    5 months ago
    Total: 623s
    #441051
  • Pipeline finished with Success
    5 months ago
    Total: 897s
    #441076
  • Pipeline finished with Skipped
    5 months ago
    #441112
  • 🇺🇸United States tim.plunkett Philadelphia

    Merged !770 🎉

  • Pipeline finished with Failed
    5 months ago
    Total: 1094s
    #441108
  • Pipeline finished with Failed
    5 months ago
    Total: 1423s
    #445423
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 454s
    #540911
  • Pipeline finished with Failed
    about 1 month ago
    Total: 752s
    #540919
  • Pipeline finished with Failed
    about 1 month ago
    Total: 790s
    #540941
  • Pipeline finished with Failed
    25 days ago
    Total: 203s
    #552379
  • Pipeline finished with Failed
    25 days ago
    Total: 196s
    #552383
  • Pipeline finished with Failed
    25 days ago
    Total: 276s
    #552775
  • Pipeline finished with Failed
    25 days ago
    Total: 204s
    #552797
  • Pipeline finished with Failed
    25 days ago
    Total: 196s
    #552817
  • Pipeline finished with Canceled
    25 days ago
    Total: 154s
    #552827
  • Pipeline finished with Failed
    25 days ago
    Total: 278s
    #552828
  • Pipeline finished with Success
    25 days ago
    Total: 206s
    #552830
  • Pipeline finished with Success
    25 days ago
    Total: 230s
    #552832
Production build 0.71.5 2024