Contrib.social

Multiple add links in breadcrumb while adding the translation to node

Open on Drupal.org →
Created on 31 March 2025, 25 days ago

Problem/Motivation

While trying to add a new Translation, we can see multiple add links in the breadcrumb section of Add new Translation Form

When clicking on it, it throws 'The website encountered an unexpected error. Try again later.'

TypeError: Drupal\content_translation\Controller\ContentTranslationController::add(): Argument #2 ($target) must be of type Drupal\Core\Language\LanguageInterface, null given in Drupal\content_translation\Controller\ContentTranslationController->add() (line 396 of core/modules/content_translation/src/Controller/ContentTranslationController.php).
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

1. Enable Content Translation and Languages module
2. Add a new Language and make the content entity translatable.
3. Create a new node and try to add the translation for it
4. You will see multiple Add buttons, and When clicking on it, it throws 'The website encountered an unexpected error. Try again later.'

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

10.4 ✨

Component

content_translation.module

Created by

🇮🇳India adwivedi008

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @adwivedi008
  • Comment 24 days ago →
    eric.vvf

    I was able to see multiple "add" buttons in the breadcrumbs. But I was able to save the translated node without any errors.

    I'm using Drupal Core 10.4.5


  • Comment 24 days ago →
    🇳🇿New Zealand quietone

    Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

  • Comment 24 days ago →
    🇳🇿New Zealand quietone
  • Comment 23 days ago →
    🇮🇳India annmarysruthy

    Was able to replicate the issue with steps mentioned in description.

    The issue occurs because the source and target parameters are explicitly set to NULL in the ContentTranslationRouteSubscriber.php file while defining the translation add route. This results in incorrect route processing, leading to duplicate "Add" links in the breadcrumb and an unexpected error when clicked.

    if ($entity_type->hasLinkTemplate('drupal:content-translation-add')) {
  $route = new Route(
    $entity_type->getLinkTemplate('drupal:content-translation-add'),
    [
      '_controller' => '\Drupal\content_translation\Controller\ContentTranslationController::add',
      'source' => NULL,
      'target' => NULL,
      '_title' => 'Add',
      'entity_type_id' => $entity_type_id,
    ],

    Removing the source and target parameters from the route definition allows Drupal to handle them dynamically based on context, preventing duplicate breadcrumb links:

    if ($entity_type->hasLinkTemplate('drupal:content-translation-add')) {
  $route = new Route(
    $entity_type->getLinkTemplate('drupal:content-translation-add'),
    [
      '_controller' => '\Drupal\content_translation\Controller\ContentTranslationController::add',
      '_title' => 'Add',
      'entity_type_id' => $entity_type_id,
    ],

    This change removes the duplicate "Add" breadcrumb links.The breadcrumb structure will now be:
    Home > Page Title > Translations.
    this ensures breadcrumb consistency with how Drupal structures breadcrumbs in other areas, such as when adding a content type (Home > Administration > Structure > Content types).

    Would love to hear thoughts from others on this approach

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024