Remove File token hook dead code

I will work on this

Removed $url_options as suggested, LanguageManagerInterface was not referenced in code.

Sorry I should have postponed this on 📌 Split File hooks into separate classes Active

The related issue to split up the File hooks was committed. The changes in the existing MR will need to be applied in the new TokenHooks class. This seems like a Novice task to me.

ok, i'll work on this

Rebased branch to incorporate the latest updates. Made changes to the TokenHook class. Note: The CronHook file has been rewritten due to updates, rendering the original modifications unnecessary.

Hello @jquijano,

I have checked the changes and it looks good to me
Also, there is no merge conflict as you already rebased the branch

Seems good to me, moving the issue to RTBC and let's wait for somemore feedback

Whenever dead code is removed we should do some digging to make sure that we aren't accidentally removing the last remnant of something that should be implemented. It is possible that this is accidentally dead code.

Therefor I used git log -L 762,767:core/modules/file/file.module to find out when $url_options was added. It was in

commit 988abc27f8b2f1a05e42932a39954dec4f18c09a
Author: Nathaniel Catchpole <catch@35733.no-reply.drupal.org>
Date:   Wed Jul 24 13:00:06 2013 +0100

    Issue #2045189 by jlindsey15: Move file entity dependent code in includes/file.inc and system.module to file.module.

I then read that issue and found $url_options in the first patch there. It was removed in the next patch after feedback from berdir. It was originally used in the several of the cases following the line of code and those were re-written. I think that confirms that we are not losing anything here.

Committed 56e3f8e and pushed to 11.x.

Thanks!

quietone → closed merge request !10553

Automatically closed - issue fixed for 2 weeks with no activity.