Wrong case for headers after using MailManagerInterface::mail()

Shreya_th → made their first commit to this issue’s fork.

Hi @AdamPS,
I have solved this issue and made changes in LegacyMailerHelper.php file and also created MR for this issue i.e. "Wrong case for headers after using MailManagerInterface::mail()" . Kindly review the changes .

Thank you .

Thanks. Needs work as tests are failing

Why don't we just change the line 96 from

$message['headers'][$name] = $header->getBodyAsString();

to

$message['headers'][$lc_name] = $header->getBodyAsString();

The idea is to use the lower case name instead of the original name.

Create a new MR for the new approach.

https://git.drupalcode.org/project/symfony_mailer/-/merge_requests/87

AdamPS → changed the visibility of the branch 3388584-header-wrong-case to hidden.

@Mingsong Because we need to match the code in MailManager.php which starts with a capital letter.

@Adam, so does it mean we need to keep $message['headers']['Reply-To'] and meanwhile also need another header $message['headers']['reply-to']?

I suggest that we should try to match MailManager exactly, so there would be only $message['headers']['Reply-to']. Note that the 't' is in lower case. So something like

$legacy_name = ($name == 'Reply-To') ? 'Reply-to' : $name;
$message['headers'][$legacy_name] = $header->getBodyAsString();

The suggested code in in #14. It goes in LegacyMailerHelper::emailToArray().

@adamps I have made the cahnges. Please review.

Thanks one comment in the MR please

@adamps Added comment, please chcek.

Thanks, it looks good to me.

We need someone to test that it works? Either run the code in a debugger, or add a debug print message, then check that the headers are as expected. If you can do that great, else we can wait for one of the other followers.

Please rebase the MR so that CI jobs at least executed properly.
With referring #21 by @adamps if there's already a test then that need to be updated.

Hello ankitv18

As per suggestions, I have rebased the branch with 2.x

Please review and suggest any other changes required