- Issue created by @AdamPS
- ๐ฎ๐ณIndia Shreya_98
Shreya_th โ made their first commit to this issueโs fork.
- Merge request !61Wrong case for headers after using MailManagerInterface::mail() issue fixed โ (Open) created by Unnamed author
- last update
9 months ago 3 pass, 4 fail - Status changed to Needs review
9 months ago 8:32am 25 September 2023 - ๐ฎ๐ณIndia Shreya_98
Hi @AdamPS,
I have solved this issue and made changes in LegacyMailerHelper.php file and also created MR for this issue i.e. "Wrong case for headers after using MailManagerInterface::mail()" . Kindly review the changes .Thank you .
- last update
9 months ago 3 pass, 4 fail - last update
9 months ago 8 fail - Status changed to Needs work
9 months ago 11:10am 26 September 2023 - First commit to issue fork.
- Merge request !87Issue #3388584: Wrong case for reply-to header after using MailManagerInterface::mail() โ (Open) created by Mingsong
- ๐ฆ๐บAustralia Mingsong ๐ฆ๐บ
Why don't we just change the line 96 from
$message['headers'][$name] = $header->getBodyAsString();
to
$message['headers'][$lc_name] = $header->getBodyAsString();
The idea is to use the lower case name instead of the original name.
Create a new MR for the new approach.
https://git.drupalcode.org/project/symfony_mailer/-/merge_requests/87
- Status changed to Needs review
5 months ago 12:40am 14 February 2024 - ๐ฌ๐งUnited Kingdom AdamPS
AdamPS โ changed the visibility of the branch 3388584-header-wrong-case to hidden.
- Status changed to Needs work
4 months ago 10:16am 14 February 2024 - ๐ฌ๐งUnited Kingdom AdamPS
@Mingsong Because we need to match the code in MailManager.php which starts with a capital letter.
- ๐ฆ๐บAustralia Mingsong ๐ฆ๐บ
@Adam, so does it mean we need to keep $message['headers']['Reply-To'] and meanwhile also need another header $message['headers']['reply-to']?
- ๐ฌ๐งUnited Kingdom AdamPS
I suggest that we should try to match MailManager exactly, so there would be only $message['headers']['Reply-to']. Note that the 't' is in lower case. So something like
$legacy_name = ($name == 'Reply-To') ? 'Reply-to' : $name; $message['headers'][$legacy_name] = $header->getBodyAsString();