Fix issues reported by PHPCS

MR Raised

Hi

I reviewed MR!15, applied against Menu Position 8.x-1.2 and there are still remaining phpcs issues shown below:

➜  menu_position git:(main) ✗ curl https://git.drupalcode.org/project/menu_position/-/merge_requests/15.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 25059    0 25059    0     0  63270      0 --:--:-- --:--:-- --:--:-- 64419
patching file CHANGELOG.txt
patching file menu_position.install
patching file 'src/Entity/MenuPositionRule.php'
patching file 'src/Form/MenuPositionRuleDeleteForm.php'
patching file 'src/Form/MenuPositionRuleForm.php'
patching file 'src/Form/MenuPositionRuleOrderForm.php'
patching file 'src/Form/MenuPositionSettings.php'
patching file 'src/Menu/MenuPositionActiveTrail.php'
patching file 'src/Plugin/Derivative/MenuPositionLink.php'
patching file 'src/Plugin/Menu/MenuPositionLink.php'
➜  menu_position git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_position

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/menu_position/src/Form/MenuPositionRuleOrderForm.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Menu\MenuLinkManagerInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/menu_position/src/Form/MenuPositionRuleForm.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
  14 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\Context\ContextRepositoryInterface.
 250 | WARNING | [ ] Unused variable $menu_name.
 303 | WARNING | [ ] Unused variable $menu_link.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

Time: 484ms; Memory: 12MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_position

Please check and advise.
Thank you.

Hello @paraderojether

I have tested the Mr using the following command

phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

and found only two open issues, which can be ignored. The rest all is fixed

FILE: menu_position/src/Form/MenuPositionRuleForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 250 | WARNING | Unused variable $menu_name.
 303 | WARNING | Unused variable $menu_link.
----------------------------------------------------------------------

Moving the issue to RTBC, and let's wait for some more feedback

Thankyou