- 🇬🇧United Kingdom catch
This needs the post update adding back from #64. You should be able to just copy the code over from the patch as a last resort given it's all new.
- Status changed to Needs review
almost 2 years ago 10:43am 14 March 2023 - 🇮🇳India _pratik_ Banglore
Add changes in system.post_update.php also.
thanks - Status changed to Needs work
almost 2 years ago 4:13am 15 March 2023 - Status changed to Needs review
almost 2 years ago 4:44am 15 March 2023 - Status changed to Needs work
almost 2 years ago 7:31pm 16 March 2023 - 🇺🇸United States smustgrave
#71 seems to be removing the code of the post_update hook
#73 seems to be adding additional changes from #71
#74 seems to be the same as #73 and adding additional changes
So patch #69 should be starting point but #70 needs to be addressed.
- Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:54am 17 March 2023 - 🇮🇳India sourabhjain
I have tried to fixed the issue mentioned in #75. Please review.
- Status changed to RTBC
almost 2 years ago 3:34pm 17 March 2023 The last submitted patch, 77: 2960643-77.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 1:44am 6 April 2023 - 🇮🇳India TanujJain-TJ
as patch #77 does not applies
error: while searching for: return $update; }); } error: patch failed: core/modules/system/system.post_update.php:93 error: core/modules/system/system.post_update.php: patch does not apply
adding a reroll for #77, please review.
- Status changed to Needs review
over 1 year ago 10:14am 6 April 2023 - Status changed to RTBC
over 1 year ago 3:42pm 6 April 2023 - Status changed to Needs work
over 1 year ago 9:32pm 10 April 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I don't see any exploration of the ::getOriginal method highlighted in #60, we've just been re-rolling the previous patch without seeing if that means we don't even need the new arguments.
Can we explore that first please? If it works the patch will be dramatically simplified.