Disabled Views display tabs have no visual indication of their state

If we are fixing this visually we should also add some indication for screen readers that a tab is disabled, as far as I can find, we don't give any indication of that either

Have tried to put the #3 comment in mind

Nice start, thanks for working on this!

The logic can probably be a bit easier to read (and without all the nested ifs and reused ifs) in something like this:

  $link_label_parts = [];

  if (!empty($variables['element']['#disabled'])) {
    $variables['is_disabled'] = TRUE;
    $link_label_parts[] = t('disabled');
  }
  if (!empty($variables['element']['#active'])) {
    $variables['is_active'] = TRUE;
    $link_label_parts[] = t('active');
  }

  // Add text to indicate active or disabled tab for non-visual users.
  if (!empty($link_label_parts)) {
    $link_label_text = t('(@states tab)', ['@states' => implode(' ', $link_label_parts)]);
    $link_label = new FormattableMarkup('<span class="visually-hidden">@label</span>', ['@label' => $link_label_text]);
    $link_text = t('@local-task-title@label', ['@local-task-title' => $link_text, '@label' => $link_label]);
  }

Didn't test this, so might need some tweaks to actually work :)

Also we need an automated test to make sure the new label is shown.

Have updated the patch as said in #7 with tests.

Have updated the patch as said in #7 with tests.

Could the issue summary be updated? The current proposed solution talks about adding some styling but the patch appears to be doing more.

As a UI change before/after screenshots in the issue summary would help too.

Also kinda nitpicky can the test theme use stark

Have not yet tested.

Thanks.

Updated the patch as per #11, that is changed the default theme to stark in the test
And added screenshot

Issue summary still needs updating please.

Thanks. Much better

The last submitted patch, 12: 3358329-12.patch, failed testing. View results →

#2001094: Design and implement style changes to signify disabled views on the Views UI edit form → closed a duplicate.

This looks close and should be converted to MR and typehints added for new functions.

Tanuj. → made their first commit to this issue’s fork.

Working on issue

Hi,
I have verified and tested MR !6316 on Drupal version 11.x
MR applied successfully...

Testing steps:

1. Install Drupal 11.x
2. Create a view with multiple display
3. Disable any one display
4. Check for disabled display tab visually changed or not
5. Apply the patch and check again for the same

Test Result:
The disable display tab changed visually, looks good to me

Attaching screenshots for reference.

Moving to RTBC

@Tanju please respect others when they said they would work on it and assigned to themselves. If a few days had passed sure that’s fine but wasn’t the case. Also was tagged for novice users which based on your post history you could work on non novice issues.
It seems the updates for type hints in #18 were not added. They were nitpicky but should still be done.

@Kanchan Bogarde when marking RTBC please read all the comments make sure everything has been addressed