- Issue created by @nod_
- Status changed to Needs review
almost 2 years ago 5:14am 14 April 2023 - 🇮🇳India gauravvvv Delhi, India
I have removed
claro/drupal.responsive-detaillibrary. As it is no longer in use. please review - 🇮🇳India TanujJain-TJ
Verified and tested patch #2, looks good to me as it removed the unused 'claro/drupal.responsive-detail' library. RTBC +1
- Status changed to Needs work
almost 2 years ago 1:28pm 14 April 2023 - 🇺🇸United States smustgrave
Searching for it here http://grep.xnddx.ru/search?text=claro%2Fdrupal.responsive-detail&filename= and see the template it use to be apart of.
Was removed in 📌 Status Report Page Update Fixed . Do we want to check if it should be added back?
The js file is also not being used anymore
- First commit to issue fork.
- @rpayanm opened merge request.
- Status changed to Needs review
almost 2 years ago 5:17pm 14 April 2023 - 🇺🇸United States rpayanm
I deleted the library entry and the JS file. Please review.
- 🇺🇸United States smustgrave
Guess if no one can see a reason to keep removing is fine.
- last update
almost 2 years ago 29,202 pass - last update
almost 2 years ago 29,283 pass - 🇬🇧United Kingdom catch
We should check that the removal was intentional and there hasn't been a regression.
- Status changed to RTBC
almost 2 years ago 11:22pm 22 April 2023 - 🇺🇸United States smustgrave
Tested on node edit screen with a number of detail tags and I didn't see anything change. Believe this was dead code as the library was never loaded.
- last update
almost 2 years ago 29,302 pass - Status changed to Fixed
almost 2 years ago 8:36am 24 April 2023 - 🇬🇧United Kingdom catch
OK given this really looks like dead code let's go ahead and remove it. Committed/pushed to 10.1.x, thanks!
- 🇳🇿New Zealand quietone
smustgrave tested this in #10, therefor removing the testing tag.
Automatically closed - issue fixed for 2 weeks with no activity.