- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:29am 29 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * Provides system time. + * + * @var \Drupal\Core\Datetime\TimeInterface + */ + protected $time; + + /** + * Constructs a WidgetBase object. + * + * @param string $plugin_id
$time contains a service instance and it should be described as such.
The short description is missing the class namespace. - Status changed to Needs work
over 1 year ago 10:39am 29 March 2023 - Status changed to Needs review
over 1 year ago 11:16am 29 March 2023 - Status changed to Needs work
over 1 year ago 1:06pm 29 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * Provides system time. + * + * @var \Drupal\Core\Datetime\TimeInterface + */ + protected $timeInterface;
It still not described as containing a service instance.
- ๐ฎ๐ณIndia _pratik_ Banglore
Added patch with #8 mentioned fix.
phpcs seems clean.
Thanks - Status changed to RTBC
over 1 year ago 4:34pm 27 April 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi _pratik_
I applied patch #9 to the โMonth Year Fieldโ module against Version 2.0.x-dev and confirmed that the errors and warnings are resolved. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
over 1 year ago 5:58pm 27 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * The date formatter interface. + * + * @var \Drupal\Core\Datetime\DateFormatterInterface + */ + protected $dateFormatter;
It is used to store a service, so it should be described as such.
+ /** + * Provides a date time service instance. + * + * @var \Drupal\Core\Datetime\TimeInterface + */ + protected $timeInterface;
The short description just need to say The time service.
+ public function __construct($plugin_id, + $plugin_definition, + FieldDefinitionInterface $field_definition, + array $settings, + array $third_party_settings, + DateFormatterInterface $date_formatter, + TimeInterface $time_interface + ) {
As per Drupal coding standards, the declaration of a method/function must use a single line.
That code is formatted as per PSR12 coding standards, which are not the Drupal coding standards. - ๐ฎ๐ณIndia zkhan.aamir
zkhan.aamir โ made their first commit to this issueโs fork.
- @zkhanaamir opened merge request.
- Status changed to Needs review
about 1 year ago 12:02pm 17 November 2023 - Status changed to Needs work
about 1 year ago 1:55pm 17 November 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * Stores date formatter service. + * + * @var \Drupal\Core\Datetime\DateFormatterInterface + */ + protected $dateFormatter;
The date formatter. is sufficient.
+ /** + * Constructs a \Drupal\month_year\Plugin\Field\FieldWidget object. + *
It should be Constructs a new โฆ.
- Assigned to nitin_lama
- Status changed to Needs review
12 months ago 1:28pm 23 November 2023 - Issue was unassigned.
- ๐ฎ๐ณIndia pray_12
Hi,
Reviewed the MR !5. Found one warning.FILE: ...onth_year/src/Plugin/Field/FieldWidget/MonthYearDefaultFieldWidget.php ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------- 45 | WARNING | Line exceeds 80 characters; contains 101 characters ----------------------------------------------------------------------------
- Status changed to RTBC
5 months ago 9:29am 14 June 2024 - ๐ฎ๐ณIndia dev16.addweb
Hello,
After testing the MR!5, I discovered no errors or warnings. I've included SS for the same as well. - Status changed to Needs review
5 months ago 7:11pm 14 June 2024