Fix the issues reported by phpcs

Created on 29 March 2023, over 1 year ago
Updated 14 June 2024, 6 months ago
๐Ÿ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia samit.310@gmail.com

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @samit.310@gmail.com
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia samit.310@gmail.com

    Above errors/warnings has been fixed.

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    +  /**
    +   * Provides system time.
    +   *
    +   * @var \Drupal\Core\Datetime\TimeInterface
    +   */
    +  protected $time;
    +
    +  /**
    +   * Constructs a WidgetBase object.
    +   *
    +   * @param string $plugin_id

    $time contains a service instance and it should be described as such.
    The short description is missing the class namespace.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia TanujJain-TJ

    adding new patch addressing points from #4.

  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    +  /**
    +   * Provides system time.
    +   *
    +   * @var \Drupal\Core\Datetime\TimeInterface
    +   */
    +  protected $timeInterface;

    It still not described as containing a service instance.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia _pratik_ Banglore

    Added patch with #8 mentioned fix.
    phpcs seems clean.
    Thanks

  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines kenyoOwen

    Hi _pratik_

    I applied patch #9 to the โ€œMonth Year Fieldโ€ module against Version 2.0.x-dev and confirmed that the errors and warnings are resolved. Please see the screenshots attached.

    For your review.
    Thank you.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    +  /**
    +   * The date formatter interface.
    +   *
    +   * @var \Drupal\Core\Datetime\DateFormatterInterface
    +   */
    +  protected $dateFormatter;

    It is used to store a service, so it should be described as such.

    +  /**
    +   * Provides a date time service instance.
    +   *
    +   * @var \Drupal\Core\Datetime\TimeInterface
    +   */
    +  protected $timeInterface;

    The short description just need to say The time service.

    +  public function __construct($plugin_id,
    +                              $plugin_definition,
    +                              FieldDefinitionInterface $field_definition,
    +                              array $settings,
    +                              array $third_party_settings,
    +                              DateFormatterInterface $date_formatter,
    +                              TimeInterface $time_interface
    +  ) {

    As per Drupal coding standards, the declaration of a method/function must use a single line.
    That code is formatted as per PSR12 coding standards, which are not the Drupal coding standards.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia zkhan.aamir

    zkhan.aamir โ†’ made their first commit to this issueโ€™s fork.

  • @zkhanaamir opened merge request.
  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sakthi_dev

    Addressed the comments in #11. Please review.

  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    +  /**
    +   * Stores date formatter service.
    +   *
    +   * @var \Drupal\Core\Datetime\DateFormatterInterface
    +   */
    +  protected $dateFormatter;

    The date formatter. is sufficient.

    +  /**
    +   * Constructs a \Drupal\month_year\Plugin\Field\FieldWidget object.
    +   *

    It should be Constructs a new โ€ฆ.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia pray_12

    Fixed the issues reported by phpcs

  • Assigned to nitin_lama
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nitin_lama India
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nitin_lama India

    Addressed #15.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nitin_lama India

    There are no changes in the MR4.

  • Merge request !53350993: MR with changes. โ†’ (Open) created by nitin_lama
  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nitin_lama India

    Please review.

  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nitin_lama India
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia pray_12

    Hi,
    Reviewed the MR !5. Found one warning.

    FILE: ...onth_year/src/Plugin/Field/FieldWidget/MonthYearDefaultFieldWidget.php
    ----------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------
     45 | WARNING | Line exceeds 80 characters; contains 101 characters
    ----------------------------------------------------------------------------
    
  • Pipeline finished with Failed
    9 months ago
    Total: 168s
    #125113
  • Pipeline finished with Failed
    9 months ago
    #125135
  • Status changed to RTBC 6 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dev16.addweb

    Hello,
    After testing the MR!5, I discovered no errors or warnings. I've included SS for the same as well.

  • Pipeline finished with Failed
    6 months ago
    Total: 138s
    #199217
  • Pipeline finished with Failed
    6 months ago
    Total: 141s
    #199240
  • Status changed to Needs review 6 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • Pipeline finished with Failed
    6 months ago
    #199254
Production build 0.71.5 2024