- Issue created by @joachim
- Status changed to Needs work
over 1 year ago 7:50am 16 July 2023 - 🇬🇧United Kingdom joachim
Pushed a simple fix, but tests will surely need updating too.
- Status changed to Needs review
over 1 year ago 9:47am 20 July 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - 🇮🇳India TanujJain-TJ
Noticed there were some grammatical errors in exception messages such as duplicate words in the commit added, so adding a patch for it along with new tests for the function and exceptions messages not sure if it is correct, please review.
- last update
over 1 year ago 29,827 pass - last update
over 1 year ago 29,804 pass, 1 fail The last submitted patch, 4: 3374856-2-test-only.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 11:44am 20 July 2023 - 🇬🇧United Kingdom joachim
Wow, so there wasn't actually any test coverage of this at all?!!!
+++ b/core/tests/Drupal/Tests/Core/Entity/ContentEntityBaseUnitTest.php @@ -669,4 +669,60 @@ public function testSet() { + $this->expectExceptionMessage("The specified translation language (de) does not exist.");That won't work -- you can't test multiple exceptions in one test method, because the execution will stop at line 700 when the first exception is thrown.