Remove duplicate "add block" link from block content type view's "Results not found" message

Created on 21 November 2019, over 4 years ago
Updated 24 July 2023, 11 months ago

Problem/Motivation

Block content's admin listing has a 'Add new block' link in the 'results not found' message.
But there is already an 'add new block' action button like every other content entity list builder.
Let's remove the duplicate link as it has a typo (no space) and duplicates an existing UX pattern in core.

Steps to reproduce

Go to custom block library page
See link for "Add custom block" in both the no results component of the view (in the table) which duplicates the action link above the table

Proposed resolution

Remove add custom block link from the no results message.

Remaining tasks

Review patch

User interface changes

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Original post

A very minor thing, I know. There is a space missing on the /admin/structure/block/block-content/ page in the sentence "There are no custom blocks available.Add a custom block." if there aren't any blocks added. Should be a space in between the two sentences.

The two sentences are put together in the core files
/core/modules/block_content/config/optional/views.view.block_content.yml
and
/core/modules/block_content/src/Plugin/views/area/ListingEmpty.php

I'm guessing there should be a better solution than to simply add a " " or a   at the end of the line in views.view.block_content.yml. If there isn't, and someone with better knowledge of Drupal core acknowledges that that is a viable solution, I could make a patch to make the work easier.

The "error" is visible in Drupal 8.7.8 and 8.7.10 as well.

๐Ÿ› Bug report
Status

Postponed

Version

11.0 ๐Ÿ”ฅ

Component
Block contentย  โ†’

Last updated less than a minute ago

Created by

๐Ÿ‡ธ๐Ÿ‡ชSweden AdamEvertsson

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024