- Status changed to Needs review
over 2 years ago 6:54pm 23 January 2023 - πΊπΈUnited States xjm
Added the below section to the policy:
https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... βThe one change I made is specifying that the "deprecate below the namespace" pattern also applies to classes with a private constructor that are intended for static use only (since the class is not instantiated, the constructor won't ever be called).
https://www.drupal.org/node/2856615/revisions/view/12898137/12939350 β
- Status changed to RTBC
over 2 years ago 7:53pm 23 January 2023 - πΊπΈUnited States smustgrave
Not sure if this is the right status
But reading the section Concrete, instantiated classes and Abstract classes, interfaces, traits, and classes with a private constructor
makes sense to me. - π³πΏNew Zealand quietone
Update Issue Summary to use current deprecation message format and @see format.
- π³πΏNew Zealand quietone
Oh, I updated the policy page as well.
So, we have agreement and the policy page is now up to date.
The last piece is to change core to follow this new policy.
- π³πΏNew Zealand quietone
Discussed with xjm and we both agree to move the work to implement this to a followup, π Update class deprecations to implement "Concrete, instantiated classes" policy Needs work .
I think we are done here.
- Status changed to Fixed
over 2 years ago 11:43pm 23 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- First commit to issue fork.
- πΊπΈUnited States xjm
Adding lots of missing credits for the discussion.