In
🐛
Remove duplicate "add block" link from block content type view's "Results not found" message
Postponed
we are adding a new post update hook that updates views configs. This has started triggering deprecation errors from other views post update hooks (at this time views_post_update_table_css_class) because ViewsConfigUpdater is created using the classResolver pattern in both the post_update and ViewsHooks::viewPresave which means $view_config_updater->setDeprecationsEnabled(FALSE); does not persist from the post update to the presave.
This is compounded by the fact that for every views post update hook, the presave is called and then all views updates are run again on every view since the presave runs updateAll. This should be fixed in a separate issue.
See https://git.drupalcode.org/issue/drupal-3095893/-/jobs/5480383
Turn ViewsConfigUpdater into a service so the class property persists.
Review
Commit
ViewsConfigUpdater is now a service
Active
11.0 🔥
views.module
To do that we need to add public API for getting the deprecationsEnabled flag, IMO this is covered by the other issue but I can see value in keeping a test around.
I've pushed something up. The test only run will fail but that'll be because the service doesn't exist so you'll have to manually edit the post update + presave hooks to see that.