- Issue created by @Grevil
- First commit to issue fork.
- Status changed to Needs work
over 1 year ago 12:09pm 25 January 2023 - Assigned to sidharth_soman
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:17am 27 January 2023 - 🇮🇳India sidharth_soman Bangalore
I have solved the fixable coding standard errors. However, there are many remaining which are to do with variable/method documentation comments. I think these would probably best be done by the maintainers. I'm moving this to 'Needs Review' for now but it's fine if someone else wants to work on the remaining errors too.
Please review this patch.
- 🇩🇪Germany Grevil
@_pratik_ already committed changes to this issue's fork, please provide your changes on top of his changes, @sidharth_soman!
- 🇮🇳India saket-001
Applying the patch #7 not remove all the standrad error till i m moving status to needs work.
- Status changed to Needs work
about 1 year ago 2:46pm 3 April 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- 🇮🇳India Rashmisoni Bangalore
Patch #7 applied. #9 image not able to find complete pending issue list so attaching pending issues.
FILE: ~/projects/drupal-d10/modules/contrib/config_partial_export/src/Commands/ConfigPartialExportCommands.php -------------------------------------- FOUND 51 ERRORS AND 2 WARNINGS AFFECTING 49 LINES ----------------------------------------- 23 | ERROR | Missing short description in doc comment 28 | ERROR | Missing member variable doc comment 30 | ERROR | Missing member variable doc comment 32 | ERROR | Missing member variable doc comment 34 | ERROR | Missing member variable doc comment 36 | ERROR | Missing member variable doc comment 38 | ERROR | Missing member variable doc comment 40 | ERROR | Missing member variable doc comment 42 | ERROR | Missing member variable doc comment 44 | ERROR | Missing short description in doc comment 49 | ERROR | Missing short description in doc comment 50 | ERROR | Missing parameter comment 51 | ERROR | Missing parameter comment 52 | ERROR | Missing parameter comment 53 | ERROR | Missing parameter comment 54 | ERROR | Missing parameter comment 55 | ERROR | Missing parameter comment 56 | ERROR | Missing parameter comment 57 | ERROR | Missing parameter comment 58 | ERROR | Missing parameter comment 59 | ERROR | Missing parameter comment 78 | ERROR | Missing parameter type 80 | ERROR | Missing parameter type 81 | WARNING | Line exceeds 80 characters; contains 112 characters 83 | WARNING | Line exceeds 80 characters; contains 88 characters 163 | ERROR | Parameter $destination_dir is not described in comment 176 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_write_config" is not in lowerCamel format 203 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_get_wildcard_keys" is not in lowerCamel format 242 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_get_changes" is not in lowerCamel format 265 | ERROR | Missing short description in doc comment 266 | ERROR | Missing parameter comment 267 | ERROR | Description for the @return value is missing 269 | ERROR | Public method name "ConfigPartialExportCommands::_user_abort" is not in lowerCamel format 269 | ERROR | Type hint "null" missing for $msg 275 | ERROR | Missing short description in doc comment 276 | ERROR | Missing parameter comment 276 | ERROR | Missing parameter type 277 | ERROR | Missing parameter comment 278 | ERROR | Missing parameter comment 279 | ERROR | Missing parameter comment 280 | ERROR | Description for the @return value is missing 282 | ERROR | Public method name "ConfigPartialExportCommands::_choice" is not in lowerCamel format 354 | ERROR | Missing short description in doc comment 355 | ERROR | Missing parameter comment 355 | ERROR | Missing parameter type 356 | ERROR | Missing parameter comment 357 | ERROR | Missing parameter comment 358 | ERROR | Missing parameter comment 359 | ERROR | Description for the @return value is missing 361 | ERROR | Public method name "ConfigPartialExportCommands::_print_table" is not in lowerCamel format 361 | ERROR | Type hint "null" missing for $handle 372 | ERROR | Doc comment is empty 375 | ERROR | Public method name "ConfigPartialExportCommands::_drush_format_table" is not in lowerCamel format --------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/config_partial_export/src/Utility/CommandHelper.php ------------------------------------------------- FOUND 25 ERRORS AFFECTING 25 LINES ----------------------------------------------- 22 | ERROR | Missing short description in doc comment 27 | ERROR | Missing member variable doc comment 29 | ERROR | Missing member variable doc comment 31 | ERROR | Missing member variable doc comment 33 | ERROR | Missing member variable doc comment 35 | ERROR | Missing member variable doc comment 37 | ERROR | Missing member variable doc comment 39 | ERROR | Missing member variable doc comment 41 | ERROR | Missing member variable doc comment 43 | ERROR | Missing short description in doc comment 48 | ERROR | Missing short description in doc comment 49 | ERROR | Missing parameter comment 50 | ERROR | Missing parameter comment 51 | ERROR | Missing parameter comment 52 | ERROR | Missing parameter comment 53 | ERROR | Missing parameter comment 54 | ERROR | Missing parameter comment 55 | ERROR | Missing parameter comment 56 | ERROR | Missing parameter comment 57 | ERROR | Missing parameter comment 58 | ERROR | Missing parameter comment 74 | ERROR | Parameter $destination_dir is not described in comment 87 | ERROR | Public method name "CommandHelper::_config_partial_export_write_config" is not in lowerCamel format 114 | ERROR | Public method name "CommandHelper::_config_partial_export_get_wildcard_keys" is not in lowerCamel format 153 | ERROR | Public method name "CommandHelper::_config_partial_export_get_changes" is not in lowerCamel format ------------------------------------------------------ Time: 196ms; Memory: 12MB - 🇮🇹Italy apaderno Brescia, 🇮🇹
See comment #8 🐛 Fix the issues reported by phpcs Needs work : The patch needs to be re-rolled.
- First commit to issue fork.
- First commit to issue fork.
- Assigned to Shruthi rao
- Issue was unassigned.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama
Remaining issues:
FILE: /home/system/Documents/contribution/config_partial_export-3336398/src/Utility/CommandHelper.php -------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------------- 130 | ERROR | Parameter $destination_dir is not described in comment 143 | ERROR | Public method name "CommandHelper::_config_partial_export_write_config" is not in lowerCamel format 170 | ERROR | Public method name "CommandHelper::_config_partial_export_get_wildcard_keys" is not in lowerCamel format 191 | WARNING | Line exceeds 80 characters; contains 81 characters 208 | ERROR | Public method name "CommandHelper::_config_partial_export_get_changes" is not in lowerCamel format -------------------------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/config_partial_export-3336398/src/Commands/ConfigPartialExportCommands.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 2 WARNINGS AFFECTING 10 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 156 | ERROR | The array declaration extends to column 142 (the limit is 80). The array content should be split up over multiple lines 233 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_write_config" is not in lowerCamel format 260 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_get_wildcard_keys" is not in lowerCamel format 281 | WARNING | Line exceeds 80 characters; contains 81 characters 298 | ERROR | Public method name "ConfigPartialExportCommands::_config_partial_export_get_changes" is not in lowerCamel format 330 | ERROR | Public method name "ConfigPartialExportCommands::_user_abort" is not in lowerCamel format 351 | ERROR | Public method name "ConfigPartialExportCommands::_choice" is not in lowerCamel format 354 | WARNING | Line exceeds 80 characters; contains 83 characters 437 | ERROR | Public method name "ConfigPartialExportCommands::_print_table" is not in lowerCamel format 451 | ERROR | Public method name "ConfigPartialExportCommands::_drush_format_table" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------------------------------- Time: 107ms; Memory: 10MB - Issue was unassigned.
- Assigned to Prem Suthar
- Status changed to Needs review
4 months ago 8:02am 26 February 2024 - 🇮🇳India Prem Suthar gujrat
Fix the all reaming issues Please review and merge This Changes.