Fix the issues reported by phpcs

FILE:~/projects/drupal-d10/modules/contrib/override_node_options/tests/src/Functional/BulkFormTest.php ------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------ 58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------ FILE:~/projects/drupal-d10/modules/contrib/override_node_options/tests/src/Functional/NodeFormTest.php ------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ------------------------------------------------------------------- 49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 192 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 232 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 236 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 240 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Form/SettingsForm.php ------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------ 12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ------------------------------------------------------------------ FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantPublishedStatusAccess.php ------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/AbstractFieldAccessOverride.php -------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------- 5 | ERROR | [x] Missing class doc comment 7 | ERROR | [ ] Missing short description in doc comment 12 | ERROR | [x] Missing function doc comment 20 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantPromoteAccess.php -------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantRevisionLogAccess.php --------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Missing function doc comment --------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantAuthoredByAccess.php -------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantStickyAccess.php ------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/FieldAccessOverrideInterface.php --------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------- 5 | ERROR | [x] Missing interface doc comment 7 | ERROR | [x] Missing function doc comment --------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FieldAccess/GrantCreatedAccess.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 12 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FormAccess/FormAccessOverrideInterface.php ------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------- 7 | ERROR | [x] Missing interface doc comment 9 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------- FILE:~/projects/drupal-d10/modules/contrib/override_node_options/src/Access/FormAccess/GrantRevisionAccess.php -------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- Time: 165ms; Memory: 10MB

Comments & Activities

Issue created by @rassoni
Issue was unassigned.
Comment over 1 year ago →
🇮🇳India rassoni Bangalore
Assigned to Bhupesh_upadhyay
Comment over 1 year ago →
🇮🇳India Bhupesh_upadhyay
Hi, I will work on this.
Issue was unassigned.
Status changed to Needs review over 1 year ago1:08pm 23 March 2023
Comment over 1 year ago →
🇮🇳India Bhupesh_upadhyay
Please review.
Comment over 1 year ago →
🇮🇳India rassoni Bangalore
Thanks @Bhupesh_upadhyay for patch. I have reviewed and tested on locally all fps issues are resolved, RTBC +
Comment over 1 year ago →
🇮🇳India Ashutosh Ahirwal India
Providing Patch
Comment over 1 year ago →
🇮🇳India saket-001
@ Ashutosh Ahirwal there is some issues in patch while applying the patch.
Comment over 1 year ago →
🇮🇳India saket-001
Patch #4 is applied successfully and fixes the all phpcs issues i.e also mentioned in #5 so i moving this to RTBC.
Status changed to Needs work over 1 year ago8:05pm 1 May 2023

Comment over 1 year ago →

🇮🇹Italy apaderno Brescia, 🇮🇹

  /**
+   * An array of context variable.
+   *
    * @var array
    */

That is not the correct description.

+  /**
+   * Static function for node edit permission.
+   */
   protected static function hasNodeEditPermission() {

That description is not correct either and it does not describe the return value.

+  /**
+   * Static function for isfieldname.
+   */
   protected static function isFieldName($fieldName) {

The description is not correct and it does not describe the parameters nor the return value.

+/**
+ * Interface for field access override.
+ */
 interface FieldAccessOverrideInterface {

That is the wrong description.

Assigned to imustakim
Comment over 1 year ago →
🇮🇳India imustakim Ahmedabad
Issue was unassigned.
Status changed to Needs review over 1 year ago9:23am 12 May 2023
Comment over 1 year ago →
🇮🇳India imustakim Ahmedabad
Patch updated.
Please review.
Comment about 1 year ago →
🇮🇳India Madhu Kumar M E
I have applied patch #11 not getting applied, please find attached screenshot for your reference.
Status changed to Closed: won't fix about 1 year ago5:56pm 3 October 2023
Comment about 1 year ago →
🇬🇧United Kingdom opdavies Wales
There's already an issue, #3295113: t() calls should be avoided in classes → , for changing the `t()` instances.

I'm not interested in adding method or class comments that repeat the name of the thing it's added to and do not add any additional value. I prefer to rely on parameter and return types to identify the types, so I will close this issue.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities