Fix issues reported by phpcs (needs reroll, not mergable no more)

Applied patch successfully all PHPCS error got fixed sharing the SS.

+/**
+ * @file
+ * For DataTable theming.
+ */

The description for that file can be better than that.

  * @see template_preprocess_table()
  */
-function template_preprocess_datatable(&$variables) {
+function template_preprocess_datatable(array &$variables) {

Drupal core does not type-hint that parameter, not even in Drupal 10.

I have uploaded the patch.
Addressed #5 point.

See my previous comment. None of the points raised there have been fixed.

Made the changes as per #5. Please review.

@sakthi_dev, Still do not see the second change suggested by @apaderno in the MR.

@mahima_mathur23 attached the screenshot. I removed the typehint array from the preprocess function.

A patch to solve all these for 2.x-dev version. To apply after other more important patches.

Some thing is wrong. An other version. Always after some other patches.

@Chris64 please prepare the fixes as MR for easier review and merging.

But perhaps you should wait until the other issues are solved, or it will be lots of rerolls / rebases.

OK @Anybody, needed to clean up the code but as the last.

@Chris64: Just one last point, then this is ready for RTBC.

Anyway I'd suggest to merge this last for the maintainer and it will need a rebase then.

@Anybody, have you see this: the MR is from #8 📌 Fix the issues reported by phpcs Needs work from @sakthi_dev and does not correspond to the patch #13 📌 Fix the issues reported by phpcs Needs work . Would you like a MR from #13? To see.

-        '#default_value' => isset($this->options['hidden_columns'][$name]) ? $this->options['hidden_columns'][$name] : 0,
+       '#default_value' => $this->options['hidden_columns'][$name] ?? 0,

should be in one of the patches I believe.

@Chris64 please change the MR accordingly. Comparing patches is a pain ;)
The change in #17 is fine.

@Anybody, here the MR associate to patch 13 → .

@Anybody, what do you think about this plan?
- try to have all the issues listed to RTBC: still this one and two others.
- then let @diqidoq act.

then let @diqidoq act.

... and that is what he will do :) ...

    Merge request can not be merged.
    Merging failed.

We possible need a reroll ofter the merges I did today, @CHris64. After you have had made the last patch/merge I think you are the best to ask for. :-)

Again, thanks for all the great work done here and in other issues. Will add a paragraph to the project page regarding the massive contrib made here and in other issues in the last 1,2 years.

@diqidoq, agree to work on it. Maybe as the last of the series of issues. Either from a corresponding release, to get a cleaned version, either from the last branch.

What about this new MR @diqidoq?

You are certified to rock @Chris64! :-) Merged and queued for upcoming 2.0.1 release!

Automatically closed - issue fixed for 2 weeks with no activity.