phpcs fixes

I have fixed some more PHPCS issues. Please review.

Hi, tested patch #3 (module version 2.0.x-dev on D10 site) using phpcs and all previous issues are resolved.

Thanks

I reverted this commit.

After applying the patch there is an dependency injection error:

ArgumentCountError: Too few arguments to function Drupal\search_api_fast\Commands\SearchApiFastCommands::__construct(), 3 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 and exactly 5 expected in /var/www/html/web/modules/contrib/search_api_fast/src/Commands/SearchApiFastCommands.php on line 94 #0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(262): Drupal\search_api_fast\Commands\SearchApiFastCommands->__construct(Object(Drupal\Core\Entity\EntityTypeManager), Object(Drupal\Core\Extension\ModuleHandler), Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))

Patch #5 doesn't apply on 2.0.x branch

Creating an MR with #3 changes. With some phpcs fixes.

I still get this error:

 [error]  ArgumentCountError: Too few arguments to function Drupal\search_api_fast\Commands\SearchApiFastCommands::__construct(), 3 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 and exactly 5 expected in Drupal\search_api_fast\Commands\SearchApiFastCommands->__construct() (line 94 of /var/www/html/web/modules/contrib/search_api_fast/src/Commands/SearchApiFastCommands.php) #0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(262): Drupal\search_api_fast\Commands\SearchApiFastCommands->__construct(Object(Drupal\Core\Entity\EntityTypeManager), Object(Drupal\Core\Extension\ModuleHandler), Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))

I'm working on this at DrupalCon 2023 Pittsburgh.

I was able to reproduce this error. I created a new instance in DrupalPod and ran the drush status, and drush returned:

gitpod /workspace/DrupalPod (main) $ drush status
Notice: running 'drush status' in ddev
PHP Fatal error:  Declaration of Drupal\search_api_fast\Commands\SearchApiFastCommands::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Drush\Commands\DrushCommands::setLogger(Psr\Log\LoggerInterface $logger): void in /var/www/html/repos/search_api_fast/src/Commands/SearchApiFastCommands.php on line 79

Fatal error: Declaration of Drupal\search_api_fast\Commands\SearchApiFastCommands::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Drush\Commands\DrushCommands::setLogger(Psr\Log\LoggerInterface $logger): void in /var/www/html/repos/search_api_fast/src/Commands/SearchApiFastCommands.php on line 79
 [warning] Drush command terminated abnormally.
Failed to execute command drush status: exit status 1
Failed to run exec_dir drush status; error=exit status 1

Tested, approved & merged the MR. Thanks

Automatically closed - issue fixed for 2 weeks with no activity.