πŸ‡ΊπŸ‡ΈUnited States @mikohl

Account created on 12 October 2018, over 5 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States mikohl

I've updated patch #5to work with the 2.0.x version of the module.

πŸ‡ΊπŸ‡ΈUnited States mikohl

The patch I previously uploaded contained an error in the youtube-block-channel.html.twig template file. This patch corrects that error.

πŸ‡ΊπŸ‡ΈUnited States mikohl

Here is a patch that addresses the Drupal 10 incompatibilities.

πŸ‡ΊπŸ‡ΈUnited States mikohl

mikohl β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States mikohl

Here is a patch for Drupal 10. This addresses the errors from the Upgrade Status module.

πŸ‡ΊπŸ‡ΈUnited States mikohl

I'm working on this at DrupalCon 2023 Pittsburgh.

I was able to reproduce this error. I created a new instance in DrupalPod and ran the drush status, and drush returned:

gitpod /workspace/DrupalPod (main) $ drush status
Notice: running 'drush status' in ddev
PHP Fatal error:  Declaration of Drupal\search_api_fast\Commands\SearchApiFastCommands::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Drush\Commands\DrushCommands::setLogger(Psr\Log\LoggerInterface $logger): void in /var/www/html/repos/search_api_fast/src/Commands/SearchApiFastCommands.php on line 79

Fatal error: Declaration of Drupal\search_api_fast\Commands\SearchApiFastCommands::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Drush\Commands\DrushCommands::setLogger(Psr\Log\LoggerInterface $logger): void in /var/www/html/repos/search_api_fast/src/Commands/SearchApiFastCommands.php on line 79
 [warning] Drush command terminated abnormally.
Failed to execute command drush status: exit status 1
Failed to run exec_dir drush status; error=exit status 1
πŸ‡ΊπŸ‡ΈUnited States mikohl

Embarrassingly, my patch in #4 πŸ“Œ Automated Drupal 10 compatibility fixes Needs review was in reverse. Here's an updated version that actually applies the update, rather than trying to remove it.

πŸ‡ΊπŸ‡ΈUnited States mikohl

After applying patch, module still caused error.

Fatal error: Declaration of Drupal\kml\Encoder\KmlEncoder::encode($data, $format, array $context = []) must be compatible with Drupal\serialization\Encoder\XmlEncoder::encode($data, $format, array $context = []): string in /code/web/modules/contrib/kml/src/Encoder/KmlEncoder.php on line 23

Attached patch updates the encode method to include the "string" return type.

πŸ‡ΊπŸ‡ΈUnited States mikohl

After Drupal 10 update, module was causing WSOD. 'FilterResponseEvent' was deprecated and replaced with 'ResponseEvent'. Patch attached includes changes in #2 ✨ Add support for Drupal 10 Fixed and updates the src/EventSubscriber/ResponseSubscriber.php file.

πŸ‡ΊπŸ‡ΈUnited States mikohl

Patch #2 fixed the issue for me. Thanks!!

Updating to RTBC.

πŸ‡ΊπŸ‡ΈUnited States mikohl

On PHP 8, the autocomplete for the State field was throwing a 500 error. Patch #3 fixes it.

Production build 0.69.0 2024