- Issue created by @Sahana _N
- Status changed to Needs review
about 1 year ago 7:39am 10 October 2023 - 🇬🇧United Kingdom schillerm
Hi, tested this and I have a capital letter! +1 for RTBC
- Status changed to RTBC
about 1 year ago 10:34pm 10 October 2023 - 🇵🇭Philippines clarkssquared
Hi, I also applied and tested the patch and I confirmed that it capitalized name of the module in .info.yml file, moving this to RTBC.
P.S. Since the issue is about the module name in info.yml I will not upload a screenshot to avoid noise in the issues.
- Status changed to Needs work
about 1 year ago 7:43am 12 October 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The module name must be capitalized in all the files where the module name is used, even if that happens in comments.
- 🇮🇳India abhaisasidharan
@apaderno I feel this issue and such issues are just for gaming the system into getting more credits. If I close this issue is it ok to not give credit? Please take a look at this: https://www.drupal.org/user/3580854/track →
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Truly, the issue is trying to fix something that effectively should be changed.
It is not correct to just change the project/module name in a single file, when there are other files where the project/module name is shown. I would rather require that what reported is done for every file where the change is necessary, but that is me. - 🇮🇹Italy apaderno Brescia, 🇮🇹
(It is gaming when the change is done for the most obvious file. If the patch/MR is provided for every file where the described change is necessary, that is less gaming, as people who provide patches or MRs must check out where the change is really necessary.)
- 🇮🇳India abhaisasidharan
Makes sense. Will merge and credit once all the relevant changes are done.
- First commit to issue fork.
- Status changed to Needs review
12 months ago 5:23am 4 December 2023 - thakurnishant_06 India
Updated as per suggested changes #5 Kindly review the changes.
- 🇬🇧United Kingdom schillerm
Hi, I have reviewed the latest version of this. Ran a case sensitive search in the module folder for "dopup" got 106 results. Looks like the module name is capitalized everywhere it should be. Hope that helps. +1 for RTBC
- Status changed to RTBC
11 months ago 10:46am 20 December 2023