The core/js-cookie asset library is deprecated in Drupal 10.1.0 and will be removed in Drupal 11.0.0

We probably should avoid using that library in 2.x and leave 8.x-1.x at status quo.

patch to use js_cookie/js-cookie instead of core/js-cookie

revised version of this patch

Hi, I tried to apply patch #4 to version 2.0.x-dev and got the error, "Could not apply patch!".
Took a look at the patch and saw that it seems to be trying to remove/update the line..

"drupal/core": "^8.9 || ^9 || ^10"

in the file /composer.json.

In version 2.0.x-dev this line does not have the ^8.9 || bit in it.
I guess this is why the patch does not apply? or am I patching against the wrong version?

That is correct: The composer.json file contains the following lines.

  "require": {
    "drupal/core": "^9 || ^10",
    "drupal/coloris": "^1"
  },

The patch does not apply to the 2.0.x branch, which is the one to change.

Raised an MR !131 against 2.0.x branch and is ready for review now. Thanks!

A bit more work needed here. See MR comments.

This is a version of the patch from the MR for the current stable version.

Thanks @lucashedding, addressed #11 MR comments.
Please review.

This looks ready.

@heddn, @ankithashetty, thanks for the contribution to v2.0.x!

This should be possible to merge (although v2 essentially does nothing at this point and can't be used), and the plan is to rewrite the code and abolish the need of js_cookie:js_cookie in version 2.0.x, or should I close it, leaving a mention that it's obsolete?

Should we leave this issue open and conclude something so that it doesn't get merged later on?

I am using this patch on the 1.x branch, not 2.x. It is only assigned to 2.x because typically develop happens on the latest branch and is backported to earlier. If that isn't the case here, we can easily just move it to 1.x, commit things and leave 2.x for a later point.

(I apologize: The status change was wrong.)

The merge request is 119 commits behind the upstream repository.

It looks like for the 1.x version of this module, js_cookie was entirely removed. That needs to be forward-ported.