- Issue was unassigned.
- ๐ฎ๐ณIndia Sonal Gyanani
Fix formatting issues in mr according to Readme.md template โ format.
Please review.
Thanks - ๐ฎ๐ณIndia Nupur Badola
Issues exist in the patch.
git.drupalcode.org_project_codesnippet_-_merge_requests_5.diff.txt:14: trailing whitespace. This module enables the CodeSnippet plugin from CKEditor.com in your git.drupalcode.org_project_codesnippet_-_merge_requests_5.diff.txt:15: trailing whitespace. WYSIWYG. It includes the highlightjs library and all available styles git.drupalcode.org_project_codesnippet_-_merge_requests_5.diff.txt:16: trailing whitespace. for it. If you've ever wanted to drop code examples in your Drupal error: patch failed: README.txt:1 error: README.txt: patch does not apply
- Status changed to Needs work
over 1 year ago 9:53am 20 June 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Sonal Gyanani
I reviewed your MR and confirmed that it is following the README.md template โ but it has missing information, example: #Table of contents. I applied your MR and there are some errors.
:14: trailing whitespace.
This module enables the CodeSnippet plugin from CKEditor.com in your
:15: trailing whitespace.
WYSIWYG. It includes the highlightjs library and all available styles
:16: trailing whitespace.
for it. If you've ever wanted to drop code examples in your Drupal
Checking patch README.txt => README.md...
error: while searching for:
CodeSnippetInstallation
============This module requires the core CKEditor module and the CodeSnippet plugin
from CKEditor.com.1. Download the CodeSnippet plugin (AT LEAST version 4.5.11) from
http://ckeditor.com/addon/codesnippet.
2. Place the plugin folder in the root libraries folder
(/libraries/codesnippet).
3. Enable CodeSnippet in the Drupal admin.
4. Configure your WYSIWYG toolbar to include the buttons.Basic Usage
===========After completing the installation steps above, go to the filter format you
want to configure (must be using CKEditor).CodeSnippet:
Drag the CodeSnippet icon into the active toolbar, and the config form will
appear below with a syntax highlighting style and supported languageserror: patch failed: README.txt:1
error: README.txt: patch does not apply - Assigned to nitin_lama
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - ๐ฎ๐ณIndia nitin_lama India
Updated README.md as per README.md template. โ
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:17am 20 June 2023 - ๐ฎ๐ณIndia Anmol_Specbee
The patch provided in comment #9 seems to be working fine, Moving to RTBC.
- Status changed to RTBC
over 1 year ago 6:37am 26 June 2023 - Status changed to Needs review
over 1 year ago 6:58pm 14 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Comment #9 does not provide patches. I am not sure what the last reviewer has reviewed.
- Status changed to Needs work
over 1 year ago 6:59pm 14 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Conflict: This file was renamed differently in the source and target branches. Ask someone with write access to resolve it.
- ๐ฎ๐ณIndia gajanan.wasnik
gajanan.wasnik โ made their first commit to this issueโs fork.
- Merge request !8Issue #3321794: Replace README.txt with README.md โ (Open) created by gajanan.wasnik
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org โCore: 10.1.4 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Status changed to Needs review
about 1 year ago 8:42am 15 October 2023 - Status changed to Needs work
about 1 year ago 3:03pm 16 October 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Conflict: This file was modified in both the source and target branches. Ask someone with write access to resolve it.
I guess there is already an issue for the same purpose.
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 1:19pm 15 February 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@apaderno
I have resolved conflict for MR !8. - Status changed to Needs work
10 months ago 9:18am 21 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!8, the file has following error
1. Configuration section is missing as it is the mandatory section
- Open on Drupal.org โCore: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 11:58am 21 February 2024 - Status changed to RTBC
10 months ago 12:09pm 26 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!8, the file is updated as per the readme.md file template.
Hence marking it to RTBC.