Fix the issues reported by phpcs

Hi Rohit Rana

I applied your patch #2 to Component blocks module against version 1.0.x-dev and confirmed that PHPCS issues relating to ComponentBlock.php were fixed. However, when I ran through PHPCS testing for the entire module there are PHPCS warnings being flagged. Moving this to Needs Work for your opinion and also the maintainers if the remaining PHPCS issues should be addressed.

Please look at the screenshots attached for your reference.

Thank you.

i will work on it.

Fixed remaining issues, please review.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

The patch is not solving all the issues. Adding a screenshot for reference.

I will work on this and will provide new patch file and interdiff file.

kindly review the new patch file.
interdiff file is also provided.

Hi The patch #12 applied cleanily. No more errors/wrnings are shown anymore.
Ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml . to check.

Thanks!

 /**
- * Implements theme_suggestions_HOOK_alter().
+ * Implements hook_theme_suggestions_block_alter().
  */
 function component_blocks_theme_suggestions_block_alter(&$hooks, &$vars) {

The correct description is Implements hook_theme_suggestions_HOOK_alter(). (See hook_theme_suggestions_HOOK_alter().)

-  if ($storage = \Drupal::routeMatch()->getParameter('section_storage')) {
-    // This is layout builder.
-    return;
-  }

Why are those lines removed?

-      $formatter_configuration = array_intersect_key($configuration, ['type' => TRUE, 'settings' => TRUE]) + ['label' => 'hidden'];
+      $formatter_configuration = array_intersect_key(
+        $configuration,
+        ['type' => TRUE, 'settings' => TRUE]) + ['label' => 'hidden'];

I would leave the code as it is, since code lines are allowed to exceed 80 characters, especially when they are easier to read.

Updated patch #12 by addressing #14, please review it.

Thanks!

Thanks @apaderno et al

Automatically closed - issue fixed for 2 weeks with no activity.