Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

   protected function getGroupMenus(GroupInterface $group) {
-    return \Drupal::service('groupmenu.menu')->loadUserGroupMenusByGroup('view', $group->id());
+    return $this->service('groupmenu.menu')->loadUserGroupMenusByGroup('view', $group->id());
   }

There is any service() method for that class or its parent classes.

+      $tree = $this->menuTree()->load($menu_name, $parameters);
+      $tree = $this->menuTree()->transform($tree, $manipulators);

That method does not exist either.

-    foreach ($this->addPageBundles($group, $create_mode) as $plugin_id => $bundle_name) {
+    foreach ($this->addPageBundles($group, $create_mode) as => $bundle_name) {

That is not correct PHP code.

 /**
- * Class GroupMenuSettingsForm.
+ * Class of GroupMenuSettingsForm.
  */

Adding a preposition is not sufficient to write a correct documentation comment. The comment is still just showing the class name, not its purpose.

     // We can't use dependency injection for entity type manager, since this
     // will cause circular dependencies.
-    $entity_type_manager = \Drupal::service('entity_type.manager');
+    $entity_type_manager = $this->service('entity_type.manager');

See the comment before the code. The maintainer is explaining why dependency injection has not been used.

Fixed rest of the phpcs issues and include #12 comment as well.

+  /**
+   * Group menu service.
+   *
+   * @var \Drupal\groupmenu\GroupMenuService
+   */
+  protected $groupMenuService;
+
+  /**
+   * Menu link tree service.
+   *
+   * @var \Drupal\Core\Menu\MenuLinkTreeInterface
+   */
+  protected $menuTree;

The descriptions are each missing an article.

+  /**
+   * Constructs a new group menu block.
+   *

The comment does not show the class name nor its namespace.

-    // We can't use dependency injection for entity type manager, since this
-    // will cause circular dependencies.
-    $entity_type_manager = \Drupal::service('entity_type.manager');
-
     $plugin_id = 'group_menu:menu';
-    $group_content_types = $entity_type_manager->getStorage('group_content_type')
+    $group_content_types = $this->entityTypeManager->getStorage('group_content_type')

We can't use dependency injection for entity type manager, since this will cause circular dependencies.

+  /**
+   * Constructs a group menu block.
+   *
+   * @param \Drupal\groupmenu\GroupMenuService $groupMenuService

The class name and its namespace are still missing from the short description.

   /**
-   * Constructs a new GroupMenuController.
+   * Constructs a GroupMenuController.
    *

The namespace is still missing.

Changes suggested by @aparderno has been incorporated in the MR changes done in #20 by @mukesh88.

Thanks for this. There is 1 thing that I noticed, the entity type manager is now injected when we explicitly didn't do that before to prevent a circular dependency.

Please review. Thanks.

apaderno → changed the visibility of the branch 3305893-phpcs-coding-standard to hidden.

GitLab CI reports some PHP_CodeSniffer warnings/errors to fix.

There is one error that needs to be addressed.

FILE: /groupmenu/src/GroupMenuConfigOverrides.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------

@pray_12, as per comment #23. we are not sure if DI issue is fixed or not. For now i have reverted the DI for entity type manager.

silvi.addweb → made their first commit to this issue’s fork.

Hi

Applied latest changes on MR !6, confirmed no errors remaining.

groupmenu git:(3.0.0-alpha1) curl https://git.drupalcode.org/project/groupmenu/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19680    0 19680    0     0  44509      0 --:--:-- --:--:-- --:--:-- 45874
patching file .gitlab-ci.yml
patching file groupmenu.module
patching file modules/groupmenu_block/src/Plugin/Block/GroupMenuBlock.php
patching file src/Access/GroupMenuAccessInterface.php
patching file src/Controller/GroupMenuController.php
patching file src/Form/GroupMenuSettingsForm.php
patching file src/GroupMenuConfigOverrides.php
patching file src/GroupMenuContentListBuilder.php
patching file src/GroupMenuListBuilder.php
patching file src/GroupMenuService.php
patching file src/GroupMenuServiceInterface.php
patching file src/Plugin/GroupContentEnabler/GroupMenu.php
patching file src/Plugin/GroupContentEnabler/GroupMenuDeriver.php
➜  groupmenu git:(3.0.0-alpha1) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig groupmenu
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

GitLab Ci no longer shows PHP_CodeSniffer warnings/errors.