- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:07pm 19 January 2023 - Assigned to hardikpandya
- Status changed to Needs work
almost 2 years ago 4:09pm 19 March 2023 - š®š³India hardikpandya
The last applied patch is not applying.
error: patch failed: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php:105 error: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php: patch does not apply
I will work on fixing this.
- @hardikpandya opened merge request.
- Status changed to Needs review
almost 2 years ago 5:02pm 19 March 2023 - š®š³India hardikpandya
Created MR that fixes all phpcs issues reported.
- Status changed to Needs work
almost 2 years ago 5:09pm 19 March 2023 - š®š¹Italy apaderno Brescia, š®š¹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:39am 20 March 2023 - Status changed to Needs work
7 months ago 12:58pm 7 June 2024 - šµšPhilippines cleavinjosh
Hi @hardikpandya,
I tried to apply MR!1 but I encountered some errors.
ā sharpspring_crm git:(1.0.x) curl https://git.drupalcode.org/project/sharpspring_crm/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 19994 0 19994 0 0 50220 0 --:--:-- --:--:-- --:--:-- 50362 patching file sharpspring_crm.module patching file src/Form/SharpSpringCrmConfigForm.php patching file src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php Hunk #6 FAILED at 98. Hunk #7 succeeded at 117 (offset 4 lines). Hunk #8 succeeded at 144 (offset 4 lines). 1 out of 8 hunks FAILED -- saving rejects to file src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php.rej patching file src/Plugin/WebformHandler/SharpSpringCrmListHandler.php patching file src/SharpSpringCrm.php ā sharpspring_crm git:(1.0.x) ā ā sharpspring_crm git:(1.0.x) ā ā sharpspring_crm git:(1.0.x) ā git restore . ā sharpspring_crm git:(1.0.x) ā ā sharpspring_crm git:(1.0.x) ā ā sharpspring_crm git:(1.0.x) ā curl https://git.drupalcode.org/project/sharpspring_crm/-/merge_requests/1.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 19994 0 19994 0 0 37761 0 --:--:-- --:--:-- --:--:-- 37724 Checking patch sharpspring_crm.module... Checking patch src/Form/SharpSpringCrmConfigForm.php... Checking patch src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php... error: while searching for: /** * {@inheritdoc} */ public function submitConfigurationForm(array &$form, FormStateInterface $form_state): void { parent::submitConfigurationForm($form, $form_state); // Save Configurations for Handler $fields = $form_state->getValues()['sharpspring']; foreach($fields as $key => $field) { if(!empty($field)) { $this->configuration[$key] = $field; } } error: patch failed: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php:105 error: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php: patch does not apply Checking patch src/Plugin/WebformHandler/SharpSpringCrmListHandler.php... Checking patch src/SharpSpringCrm.php... ā sharpspring_crm git:(1.0.x) ā
Please check and advise.
Thank you. - Status changed to Needs review
5 months ago 8:37am 18 July 2024 - šµšPhilippines cleavinjosh
Hi,
I fixed the phpcs issues.
Please review. Thank you.