Fix the issues reported by phpcs

Created on 24 June 2022, over 2 years ago
Updated 18 July 2024, 4 months ago
šŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Harsh panchal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Assigned to hardikpandya
  • Status changed to Needs work over 1 year ago
  • šŸ‡®šŸ‡³India hardikpandya

    The last applied patch is not applying.

    error: patch failed: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php:105
    error: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php: patch does not apply

    I will work on fixing this.

  • @hardikpandya opened merge request.
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India hardikpandya

    Created MR that fixes all phpcs issues reported.

  • Status changed to Needs work over 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs work 5 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @hardikpandya,

    I tried to apply MR!1 but I encountered some errors.

    āžœ  sharpspring_crm git:(1.0.x) curl https://git.drupalcode.org/project/sharpspring_crm/-/merge_requests/1.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 19994    0 19994    0     0  50220      0 --:--:-- --:--:-- --:--:-- 50362
    patching file sharpspring_crm.module
    patching file src/Form/SharpSpringCrmConfigForm.php
    patching file src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php
    Hunk #6 FAILED at 98.
    Hunk #7 succeeded at 117 (offset 4 lines).
    Hunk #8 succeeded at 144 (offset 4 lines).
    1 out of 8 hunks FAILED -- saving rejects to file src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php.rej
    patching file src/Plugin/WebformHandler/SharpSpringCrmListHandler.php
    patching file src/SharpSpringCrm.php
    āžœ  sharpspring_crm git:(1.0.x) āœ—
    āžœ  sharpspring_crm git:(1.0.x) āœ—
    āžœ  sharpspring_crm git:(1.0.x) āœ— git restore .
    āžœ  sharpspring_crm git:(1.0.x) āœ—
    āžœ  sharpspring_crm git:(1.0.x) āœ—
    āžœ  sharpspring_crm git:(1.0.x) āœ— curl https://git.drupalcode.org/project/sharpspring_crm/-/merge_requests/1.diff | git apply -v
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 19994    0 19994    0     0  37761      0 --:--:-- --:--:-- --:--:-- 37724
    Checking patch sharpspring_crm.module...
    Checking patch src/Form/SharpSpringCrmConfigForm.php...
    Checking patch src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php...
    error: while searching for:
      /**
       * {@inheritdoc}
       */
      public function submitConfigurationForm(array &$form, FormStateInterface $form_state): void
      {
        parent::submitConfigurationForm($form, $form_state);
    
        // Save Configurations for Handler
        $fields = $form_state->getValues()['sharpspring'];
        foreach($fields as $key => $field) {
          if(!empty($field)) {
            $this->configuration[$key] = $field;
          }
        }
    
    error: patch failed: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php:105
    error: src/Plugin/WebformHandler/SharpSpringCrmLeadHandler.php: patch does not apply
    Checking patch src/Plugin/WebformHandler/SharpSpringCrmListHandler.php...
    Checking patch src/SharpSpringCrm.php...
    āžœ  sharpspring_crm git:(1.0.x) āœ—

    Please check and advise.
    Thank you.

  • Pipeline finished with Success
    5 months ago
    Total: 139s
    #193737
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs review 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi,

    I fixed the phpcs issues.

    Please review. Thank you.

  • Pipeline finished with Success
    4 months ago
    Total: 151s
    #227627
Production build 0.71.5 2024