Fix the issues reported by phpcs

Created on 19 April 2023, over 1 year ago
Updated 8 May 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/contribution/drupal10/web/modules/contrib/wscf/wscf.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: /var/www/html/contribution/drupal10/web/modules/contrib/wscf/README.md
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 146 characters
10 | WARNING | Line exceeds 80 characters; contains 126 characters
12 | WARNING | Line exceeds 80 characters; contains 109 characters
17 | WARNING | Line exceeds 80 characters; contains 127 characters
----------------------------------------------------------------------------

FILE: ...ntribution/drupal10/web/modules/contrib/wscf/src/Plugin/Block/WscfTwig.php
--------------------------------------------------------------------------------
FOUND 13 ERRORS AND 7 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] There must be one blank line after the last USE statement;
| | 2 found;
18 | ERROR | [x] There must be exactly one newline after the class comment
22 | ERROR | [x] No space found before comment text; expected "//
| | getCarbonFootprint function that uses promise in async
| | mode, waits for" but found "//getCarbonFootprint function
| | that uses promise in async mode, waits for"
23 | WARNING | [x] There must be no blank line following an inline comment
23 | WARNING | [ ] There must be no blank line following an inline comment
23 | ERROR | [x] No space found before comment text; expected "// the api
| | response and return the output in json format." but found
| | "//the api response and return the output in json format."
25 | ERROR | [x] You must use "/**" style comments for a function comment
28 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | ]
31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
33 | ERROR | [x] Inline comments must start with a capital letter
33 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
33 | ERROR | [x] Comments may not appear after statements
37 | WARNING | [ ] Line exceeds 80 characters; contains 184 characters
37 | WARNING | [x] There must be no blank line following an inline comment
37 | WARNING | [ ] There must be no blank line following an inline comment
37 | ERROR | [x] No space found before comment text; expected "// build
| | function that pass the url to getCarbonFootprint and waits
| | for the response. once the api answer will pass the content
| | to the carbon_footprint structure in the wscf template."
| | but found "//build function that pass the url to
| | getCarbonFootprint and waits for the response. once the api
| | answer will pass the content to the carbon_footprint
| | structure in the wscf template."
37 | ERROR | [x] Inline comments must start with a capital letter
39 | ERROR | [x] You must use "/**" style comments for a function comment
40 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
44 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ml/contribution/drupal10/web/modules/contrib/wscf/templates/wscf.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
21 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/contribution/drupal10/web/modules/contrib/wscf/wscf.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
7 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block templates."
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 303ms; Memory: 8MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig wscf/

Proposed resolution

Fix all the issues reported for Drupal and DrupalPractice.

Remaining tasks

Patch review.

๐Ÿ“Œ Task
Status

Fixed

Version

1.1

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024