When you say "This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer." Does the amount of PHP code in a project influence whether it's eligible for the Drupal Security Advisory? The module serves its purpose. Regarding your question, Not really, I've contributed with patches to the openid_connect_windows_aad module (features requests).
I just rescanned the code with phpcs --standard="Drupal,DrupalPractice" -n \ --extensions="php,module,inc,install,test,profile,theme" \ and found two issues. I've fixed them already and pushed the changes.
Thanks.
eduardo.arana β created an issue.
Added patch for 2.0.0-beta5 version/branch.
eduardo.arana β created an issue.
Adding the patch with the fixes.
Please review it again, this affects 3.0.0-alpha2 version and the warning and deprecated function are not related with https://www.drupal.org/project/openid_connect/issues/3266452 π Adding Generic Oauth2 app and set empty scope then cause system crash RTBC
Thanks.
eduardo.arana β created an issue.
eduardo.arana β created an issue.
eduardo.arana β made their first commit to this issueβs fork.
thanks gayatri chahar for this patch. I've applied to the current code.
eduardo.arana β made their first commit to this issueβs fork.