Adding Generic Oauth2 app and set empty scope then cause system crash

TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in implode() (line 98 of /opt/drupal/web/modules/contrib/openid_connect/src/Plugin/OpenIDConnectClient/OpenIDConnectGenericClient.php) #0 /opt/drupal/web/modules/contrib/openid_connect/src/Plugin/OpenIDConnectClient/OpenIDConnectGenericClient.php(98): implode() #1 /opt/drupal/web/modules/contrib/openid_connect/src/Form/OpenIDConnectClientFormBase.php(105): Drupal\openid_connect\Plugin\OpenIDConnectClient\OpenIDConnectGenericClient->buildConfigurationForm() #2 [internal function]: Drupal\openid_connect\Form\OpenIDConnectClientFormBase->buildForm() #3 /opt/drupal/web/core/lib/Drupal/Core/Form/FormBuilder.php(531): call_user_func_array() #4 /opt/drupal/web/core/lib/Drupal/Core/Form/FormBuilder.php(278): Drupal\Core\Form\FormBuilder->retrieveForm() #5 /opt/drupal/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm() #6 [internal function]: Drupal\Core\Controller\FormController->getContentResult() #7 /opt/drupal/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array() #8 /opt/drupal/web/core/lib/Drupal/Core/Render/Renderer.php(564): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #9 /opt/drupal/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext() #10 /opt/drupal/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() #11 /opt/drupal/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #12 /opt/drupal/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw() #13 /opt/drupal/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle() #14 /opt/drupal/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle() #15 /opt/drupal/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle() #16 /opt/drupal/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass() #17 /opt/drupal/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle() #18 /opt/drupal/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() #19 /opt/drupal/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() #20 /opt/drupal/web/core/lib/Drupal/Core/DrupalKernel.php(708): Stack\StackedHttpKernel->handle() #21 /opt/drupal/web/index.php(19): Drupal\Core\DrupalKernel->handle() #22 {main}

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇨🇳China dravenk
The #3 just a use case. The description provides the simply steps to reproduce. There are only two steps then you get the result of the system crashing.
Comment over 1 year ago →
🇨🇳China dravenk
Comment over 1 year ago →
🇨🇳China dravenk
Status changed to Needs review over 1 year ago5:16am 30 March 2023
Comment over 1 year ago →
🇨🇳China dravenk
Status changed to RTBC over 1 year ago9:20am 30 March 2023
Comment over 1 year ago →
🇵🇭Philippines clarkssquared
Hi dravenk,

I confirmed the issue was resolved when I applied MR!43 to the "OpenID Connect / OAuth client" module against Version 3.x-dev in my local.

Please see the screenshots attached for your reference.

For your review.
Thank you.

Adding Generic Oauth2 app and set empty scope then cause system crash

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities