Fix the issues reported by phpcs

Created on 11 April 2023, almost 2 years ago
Updated 22 May 2023, almost 2 years ago

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/mdrop_suite.routing.yml
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access
| | administration pages" which is about viewing but not changing configurations.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_layout_builder/css/mdrop-suite-layout-builder.css
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
241 | ERROR | [ ] Class definition is empty
415 | ERROR | [x] Expected 1 space after colon in style definition; 2 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_layout_builder/src/MdropSuiteLayoutBuilderPreRender.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Whitespace found at end of line
47 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
47 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_layout_builder/mdrop_suite_layout_builder.module
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
43 | ERROR | The array declaration extends to column 128 (the limit is 80). The array content should be split up over multiple lines
43 | ERROR | The array declaration extends to column 127 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldImageTrait.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldRemoteVideoTrait.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldWebformTrait.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldLocalVideoTrait.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldTextTrait.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldCtaTrait.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing trait doc comment
11 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/BundleField/MdropSuiteBundleFieldParagraphTrait.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing trait doc comment
10 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/src/MdropSuiteBundleFieldHelper.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [ ] Missing member variable doc comment
26 | ERROR | [x] Missing function doc comment
30 | ERROR | [x] Missing function doc comment
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_bundle_field/mdrop_suite_bundle_field.info.yml
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_media/src/MdropSuiteMediaHelper.php
------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
36 | ERROR | [ ] Doc comment short description must end with a full stop
39 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
42 | ERROR | [x] Space found before object operator
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_layout/css/mdrop-suite-layout.css
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_layout/src/Plugin/Layout/MdropSuiteLayoutBase.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 1 WARNING AFFECTING 25 LINES
--------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
20 | ERROR | [ ] Missing member variable doc comment
21 | ERROR | [ ] Missing member variable doc comment
33 | ERROR | [x] Missing function doc comment
35 | ERROR | [x] Missing function doc comment
37 | ERROR | [x] Missing function doc comment
41 | ERROR | [x] Missing function doc comment
50 | ERROR | [x] Missing function doc comment
59 | ERROR | [x] Missing function doc comment
69 | ERROR | [x] Missing function doc comment
77 | ERROR | [x] Missing function doc comment
85 | ERROR | [x] Missing function doc comment
92 | ERROR | [x] Missing function doc comment
105 | ERROR | [x] Missing function doc comment
120 | ERROR | [x] Missing function doc comment
323 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
387 | ERROR | [x] Whitespace found at end of line
387 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
388 | ERROR | [x] Whitespace found at end of line
404 | ERROR | [x] Whitespace found at end of line
447 | ERROR | [x] Whitespace found at end of line
457 | ERROR | [x] Whitespace found at end of line
496 | ERROR | [x] Whitespace found at end of line
546 | ERROR | [x] Whitespace found at end of line
546 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
547 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_modal/src/MdropSuiteModalHelper.php
------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------
95 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
105 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
167 | ERROR | [ ] Type hint "array" missing for $links
222 | ERROR | [x] Data types in @param tags need to be fully namespaced
236 | ERROR | [x] Data types in @param tags need to be fully namespaced
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_modal/src/MdropSuiteModalLayoutBuilderPreRender.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_modal/src/EventSubscriber/MdropSuiteModalRouteSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
14 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_modal/src/MdropSuiteModalLibraryDiscoveryCollector.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_modal/src/Form/MdropSuiteModalSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------
93 | ERROR | [x] Expected one space after the comma, 0 found
93 | ERROR | [x] Expected one space after the comma, 0 found
118 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/mdrop_suite_block.module
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
30 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/src/Controller/MdropSuiteBlockChooseBlockController.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
45 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 0
45 | ERROR | [x] 8 spaces found before inline comment; expected "// dpm($category_key);" but found "// dpm($category_key);"
51 | ERROR | [ ] Parameter $category_key is not described in comment
61 | WARNING | [x] '@TODO!' should match the format '@todo Fix problem X here.'
62 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
77 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/src/MdropSuiteBlockHelper.php
------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
36 | ERROR | [ ] Doc comment short description must end with a full stop
39 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
42 | ERROR | [x] Space found before object operator
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_webform/mdrop_suite_block_webform.module
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_paragraph/mdrop_suite_block_paragraph.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_cta/mdrop_suite_block_cta.module
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_remote_video/mdrop_suite_block_remote_video.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_local_video/mdrop_suite_block_local_video.module
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_image/mdrop_suite_block_image.module
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/mdrop_suite/modules/mdrop_suite_block/modules/mdrop_suite_block_text/mdrop_suite_block_text.module
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------

📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇮🇳India himanshu_jhaloya Indore

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @himanshu_jhaloya
  • @himanshu_jhaloya opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to RTBC almost 2 years ago
  • 🇮🇳India Mahima_Mathur23

    Verified the MR. All the issues are resolved, post applying the patch. Attaching screenshot for reference.
    Moving to RTBC.

  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
    +   * @param string $category_key
    +   *   Category key.
    

    That description is not sufficient. It is only repeating the parameter name with two characters less.

    -      // @TODO!
    -      // $icon_url = \Drupal::service('file_url_generator')->generateString($icon_base_path . 'linuxfoundation.svg');
    +      // @todo !
    +      // $icon_url = \Drupal::service('file_url_generator')->
    +      // generateString($icon_base_path . 'linuxfoundation.svg');
    

    What follows @todo must be a sentence. ! is not a sentence.

    +/**
    + * {@inheritDoc}
    + */
     trait MdropSuiteBundleFieldCtaTrait {

    {@inheritDoc} is not used in the documentation comment for a trait.

    +  /**
    +   * The entity definitions update manager service.
    +   *
    +   * @var \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface
    +   */
       protected $entityDefinitionsUpdateManager;
    

    That is not the correct description.

    +  /**
    +   * {@inheritDoc}
    +   */
       public function installBlockContentBundleFields($bundle_key, $class) {
         $this->installEntityTypeBundleFields('block_content', $bundle_key, $class);
       }

    In a class that does not extend another class nor does implement an interface, {@inheritDoc} cannot be used.

     /**
    - * Class MdropSuiteLayoutBase.
    + * Class os MdropSuiteLayoutBase.
      */

    No, adding a random word between Class and the class name is not sufficient for the comment to just repeat the class name. It is still repeating the class name and not giving any information about the class purpose.

    +  /**
    +   * {@inheritDoc}
    +   */
       abstract protected function getWidthOptions();

    I take that is not a method defined in a parent class or an interface. That documentation comment is wrong. {@inheritDoc} is not a replacement for every documentation comment somebody is not able to write.

        * @param string $bundle_key
    -   *  Media bundle key.
    +   *   Media bundle key.

    The description is missing an article. I know that is what the existing comment says, but since the comment is changed, it should be changed to make it correct.

    +  /**
    +   * Mdrop_suite_modal constructor.
    +   *
    +   * @param \Drupal\Core\Asset\LibraryDiscoveryInterface $library_discovery
    +   *   The LibraryDiscovery service.
    +   */
    +  public function __construct(LibraryDiscoveryInterface $library_discovery) {

    The short description must include the class name, its namespace, and start with a verb, for example Constructs a new \Drupal\user\Entity\User object.

        * @return bool
    -   *  Result.
    +   *   Result.

    That is not a sufficient description for the return value.

    - * Class MdropSuiteModalLibraryDiscoveryCollector.
    + * Class LibraryDiscoveryCollector MdropSuiteModalLibraryDiscoveryCollector.

    The documentation comment needs to say what the class purpose is, not the class name and the parent class name.

  • Status changed to Closed: won't fix almost 2 years ago
  • 🇪🇸Spain tunic Madrid

    Thanks for your time, unfortunately this module is not longer developed because it has been superseded by VLSuite .

Production build 0.71.5 2024