- Issue created by @dineshkumarbollu
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:48am 2 May 2023 - Status changed to Needs work
over 1 year ago 5:18am 2 May 2023 - ๐ต๐ญPhilippines paraderojether
Hi dineshkumarbollu
I reviewed patch #2, and the patch is falied or not completely applied and there is still remaining warning shown below:
FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/redirect_options/redirect_options.info.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-----------------------------------------------------------------------------------------------------------------Time: 297ms; Memory: 10MB
Please check.
Thank You. - Status changed to Needs review
over 1 year ago 8:33am 2 May 2023 - ๐ฎ๐ณIndia Mahima_Mathur23
I confirm that there is no phpcs issue after applying Patch #2.
Please refer the screenshot. - Status changed to Needs work
over 1 year ago 9:47am 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - redirect + - drupal: redirect
The Redirect โ module is not a Drupal core module.
Also, there should not be spaces between the project name and the module name. - Status changed to Needs review
over 1 year ago 10:01am 2 May 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Providing patch with solution
Please review. - Status changed to Needs work
over 1 year ago 11:30am 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - redirect + - redirect: redirect
The space must be removed.
- Status changed to Needs review
over 1 year ago 12:23pm 11 May 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Hi, I have removed space according to #7 ๐ Fix the issues reported by phpcs RTBC
- Status changed to Needs work
over 1 year ago 12:44pm 11 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 2:29pm 11 May 2023 - Status changed to RTBC
over 1 year ago 3:06am 12 May 2023 - ๐ต๐ญPhilippines paraderojether
I reviewed patch #8 and confirmed it fixes all the issues reported by phps. Drupal core version 9.5.8, Redirect Options 2.1.1
I added screenshot for reference.
Thank You.