Fix the issues reported by phpcs

Created on 2 May 2023, over 1 year ago
Updated 12 May 2023, over 1 year ago

Problem/Motivation

โฏ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

FILE: /Users/specbee/Sites/Projects/redirect_options/redirect_options.info.yml
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/redirect_options/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 100 characters
  6 | WARNING | Line exceeds 80 characters; contains 121 characters
  7 | WARNING | Line exceeds 80 characters; contains 123 characters
  8 | WARNING | Line exceeds 80 characters; contains 128 characters
 12 | WARNING | Line exceeds 80 characters; contains 133 characters
 14 | WARNING | Line exceeds 80 characters; contains 114 characters
 15 | WARNING | Line exceeds 80 characters; contains 98 characters
 16 | WARNING | Line exceeds 80 characters; contains 295 characters
----------------------------------------------------------------------

Time: 129ms; Memory: 10MB

Steps to reproduce

Run following command
phpcs --standard=โ€œDrupal,DrupalPracticeโ€ --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

๐Ÿ“Œ Task
Status

RTBC

Version

2.1

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia dineshkumarbollu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @dineshkumarbollu
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines paraderojether

    Hi dineshkumarbollu

    I reviewed patch #2, and the patch is falied or not completely applied and there is still remaining warning shown below:

    FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/redirect_options/redirect_options.info.yml
    -----------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------
    7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
    -----------------------------------------------------------------------------------------------------------------

    Time: 297ms; Memory: 10MB

    Please check.
    Thank You.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Mahima_Mathur23

    I confirm that there is no phpcs issue after applying Patch #2.
    Please refer the screenshot.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    -  - redirect
    +  - drupal: redirect

    The Redirect โ†’ module is not a Drupal core module.
    Also, there should not be spaces between the project name and the module name.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Ashutosh Ahirwal India

    Providing patch with solution
    Please review.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
    -  - redirect
    +  - redirect: redirect

    The space must be removed.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Ashutosh Ahirwal India

    Hi, I have removed space according to #7 ๐Ÿ“Œ Fix the issues reported by phpcs RTBC

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada imustakim Canada

    Issue summary updated.

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines paraderojether

    I reviewed patch #8 and confirmed it fixes all the issues reported by phps. Drupal core version 9.5.8, Redirect Options 2.1.1

    I added screenshot for reference.
    Thank You.

Production build 0.71.5 2024